search

vasia / gelly-streaming

An experimental Graph Streaming API for Apache Flink
Apache License 2.0
140 stars 44 forks source link

updating fold function #17

Closed Zainab-Abbas closed 8 years ago

Zainab-Abbas commented 8 years ago

changed PartialAgg class in WindowGraphAggregation.java

vasia commented 8 years ago

Thank you @Zainab-Abbas! I have left a few easy-to-fix comments.

Zainab-Abbas commented 8 years ago

made some small fixes :)

vasia commented 8 years ago

Thanks @Zainab-Abbas! Changes look good. Can you please revert all unrelated formatting changes? It seems that your IDE likes adding tabs :) I'll merge afterwards.

Zainab-Abbas commented 8 years ago

@vasia I do not know why IDE keeps adding spaces every time i format it, its adding even more spaces my current settings:

use tab character option checked

Tab size: 4 Indent: 4 Continuation indent: 8

let me know if this has to be changed

Zainab-Abbas commented 8 years ago

ok i got the issue the pervious WindowGraphAggregation.java is not formatted correctly this one is correct as the IDE gives notification about previous one not being indented properly.

I can revert it back to fewer spaces if you want, but i checked other code files they are according to my current commit.