search

vasl-developers / vasl

Virtual Advanced Squad Leader
http://vasl.info/
GNU Lesser General Public License v2.1
66 stars 27 forks source link

vasl calculates vertex hindrance differently with different board configurations #1362

Open jrvjrv opened 1 year ago

jrvjrv commented 1 year ago

Tracing LOS wH3 to wJ9 should have four hindrances. If the board configuration has board w alone, vasl reports three.

vasl bug hindrance_hexside

If I add a row above with board y in it, vasl reports four hindrances for the same LOS

vasl bug los hindrances

derimmer commented 1 year ago

Didn't we have a similar situation just recently? I think it involved flipped boards.

jrvjrv commented 1 year ago

There's this, which seems sort-of similar. Other than that I can't find anything with an admittedly shallow search.

derimmer commented 8 months ago

This is due to slightly wonky geometry in VASL. Note that in two cases (H5-I5-I6 and J7-I6-I7) the LOS cuts very close to the vertex. A very minor one-pixel shift to the left or the right could push the LOS out of the Orchard Hindrance hex (H5 or J7). That is what is happening. No real way to fix it.