search

vasl-developers / vasl

Virtual Advanced Squad Leader
http://vasl.info/
GNU Lesser General Public License v2.1
66 stars 28 forks source link

HIP Fortification Bug #1755

Open derimmer opened 4 months ago

derimmer commented 4 months ago

Transferred from VASSAL#2817

Same repeatable bug. Go to the right (north) and grab the "?" 251/1 halftrack and move (drag it) one hexe south (or left) into 86J7. Crashes, twice now.

VASL v6.6.9-beta2 3.7.12

https://github.com/vassalengine/modules/issues/2827

derimmer commented 4 months ago

Second bug:

https://www.gamesquad.com/forums/index.php?threads/auto-reveal-hip-fortifications.195813/page-2#post-2168764

seems there is a conflict between the auto-reveal feature and the hideable control markers extension.

derimmer commented 4 months ago

wrt vassal bug 2827, using VASL6.6.9-beta3, I cannot replicate it. It may be that in making other changes to the HIP Fortification code, I have resolved this bug. I tested this offline and online.

Edit: it appears that this was likely due to a version mismatch. I am going to try and add some code to the the HIP Fortification code to prevent its use when version mismatch is present in online game.

derimmer commented 4 months ago

@apbills Alan, could I get your help on the second bug? I have been able to recreate the problem (frankly it's not that big a deal in that it is quite easy to fix in-game but it is a bug) and it definitely seems tied to the presence of the HCM extension. I am reluctant to play around with the extension without your advice and direction.

apbills commented 3 months ago

The second bug is not related to the HIP-fortification implementation. The rendering of the overlays and their stacking with the HCM extension present occurs prior to the HIP fortification function in 6.6.9.

It is due to the addition of the layer capability in the Map window. The HCM implementation only defines two "Layer" elements, "perimeter" and "control". If there is no marker with identify of "layer" then you end up in the non-defined layer, which means everything other than perimeter and control markers from the HCM are in that layer, which is rendered above the HCM defined layers. What is not clear to me (yet) is what within VASL renders the overlays and control markers in the base module on the bottom. Is it a marker (like "Location") or is it the non-stackable trait. I am continuing to look into that part of the issue.

It is clear that by adding defined layers to a map window it partially overrules the non-stackable trait in that the layers are treated as overarching and then the non-stackable trait is treated within its own layer bin (be it a defined or non-defined layer).

apbills commented 2 months ago

I believe the only way to fix the stacking issues would be to move the HCM extension into the main VASL module and then add additional "layer" markers for the overlays and any other thing to be set in its stacking order. Effectively you could define another layer as "overlay" or better 2 or more types of overlays ("terrain", "GameAid", etc.) and then make them stack in the order you want. Actually, you would just need to take the map layer definition out of the extension and put it in the main module (with the added layers define).