vasl-developers / vasl

Virtual Advanced Squad Leader
http://vasl.info/
GNU Lesser General Public License v2.1
67 stars 29 forks source link

Primosole Bridge map (PBR) hexes are mis-reporting #191

Closed davidsullivan317 closed 9 years ago

davidsullivan317 commented 9 years ago

On the Primosole Bridge map the hex numbers for hexes in columns A, C, E, etc. are off by one.

pbr-sample

BigAl737 commented 9 years ago

The problem is alternate hex grain numbering is not in use. Also, this board hasn't been converted to Metadata. I've created a metadata file (pasted below) but still am getting an error. What's the proper syntax for "alternate=true" in metadata?

<?xml version="1.0"?>

-

-

-

-

davidsullivan317 commented 9 years ago

Use: altHexGrain="true"

Note that this code has never been used before so you'll have to test carefully.

BigAl737 commented 9 years ago

It seems I have a working metadata file but still recognition of the alternate hex grain. I've attached what I've got so far. If you have time, please check to see if I'm overlooking something obvious. Thanks. Hmmm, can't attach a zip file. I'll email it to you.

davidsullivan317 commented 9 years ago

Looks like there's a bug if there's no data file in the archive. I've fixed it and a new build is available here: https://www.dropbox.com/s/ftweppp8jqrqx5i/vasl-6.3.0-Snapshot-20150329.vmod?dl=0

Also note that you have to set the location of A1 center dot on this map;

<boardMetadata name="PBR" version="1.1" versionDate="Mar 2015" author="TR" boardImageFileName="bdPBR.gif" hasHills="FALSE" width="25" height="28" A1CenterX = "1" A1CenterY = "98" altHexGrain="true">

BigAl737 commented 9 years ago

Thanks David,

Got the hex row ID issue fixed but the LOS string is off 8 pixels at the bottom of the map. What’s the metadata syntax to define dx and dy?

Al

From: David Sullivan Sent: Sunday, March 29, 2015 5:08 PM To: vasl-developers/vasl Cc: Allan Cannamore Subject: Re: [vasl] Primosole Bridge map (PBR) hexes are mis-reporting (#191)

Looks like there's a bug if there's no data file in the archive. I've fixed it and a new build is available here: https://www.dropbox.com/s/ftweppp8jqrqx5i/vasl-6.3.0-Snapshot-20150329.vmod?dl=0

Also note that you have to set the location of A1 center dot on this map;

name="PBR" version="1.1" versionDate="Mar 2015" author="TR" boardImageFileName="bdPBR.gif" hasHills="FALSE" width="25" height="28" A1CenterX = "1" A1CenterY = "98" altHexGrain="true">

— Reply to this email directly or view it on GitHub.

davidsullivan317 commented 9 years ago

The syntax for dx and dy are:

A1CenterX = "1"
A1CenterY = "98"

It looks like the map uses a custom hex size. You'll have to figure this out by doing a little arithmetic with the image. Then use the following in the metadata:

hexHeight = "x.x"
hexWidth = "x.x"

Fiddle around with these 4 values until everything lines up.

BigAl737 commented 9 years ago

This issue is fixed. Thanks for your help David. Doesn't look like the PBR board has a home in src so I won't commit it. Let me know where to send it and we can close this issue.

davidsullivan317 commented 9 years ago

Do you want to try adding it to Github? Just create a folder in boards/src and add all of the files in the archive. You got this!

BigAl737 commented 9 years ago

Done?

BigAl737 commented 9 years ago

Done!