search

vasl-developers / vasl

Virtual Advanced Squad Leader
http://vasl.info/
GNU Lesser General Public License v2.1
66 stars 27 forks source link

VASL 6.3 release discussion #208

Closed davidsullivan317 closed 8 years ago

davidsullivan317 commented 9 years ago

I hadn't planned on releasing VASL 6.3 so soon, but Jeff has the HP counters ready and I think it's worth pushing out sooner rather than later. I know I'd like to try an HP scenario on VASL!

I have two large/complicated changes in this release and would appreciate it if people could commit an hour or two to testing them:

Automated board updates #205 Sunset the old board SSR text files #117

Also, please review the HP if you can.

You can find the initial build here: https://www.dropbox.com/s/qz8wwsf0thfkgis/vasl-6.3.0-Snapshot-20150327.vmod?dl=0

zgrose commented 9 years ago

Re: the Finnish counters: Are we going with counter scans as an interim get-it-out the door solution or is the preferred long term solution for counters?

screen shot 2015-03-28 at 10 09 00 am

mistertakai commented 9 years ago

I asked MMP to donate counter graphics to VASL.

mistertakai commented 9 years ago

More HP counter samples:

image

davidsullivan317 commented 9 years ago

All changes to date have been incorporated in this build: https://www.dropbox.com/s/8up2799llacp1rm/vasl-6.3.0-Snapshot-20150331.vmod?dl=0

IMPORTANT - please make any future changes to this module file.

Wargamerx commented 9 years ago

Doesn't help. The existing VASL counters are redrawn. The scans I got looked great at 300 pixels per inch, the problem is they turn to crap when you reduce it to 96 ppi. A 60 by 60 image isn't really sufficient to store the art work and data on a 5/8" counter.

Sent from my iPad

On Mar 28, 2015, at 1:45 PM, Daniel Takai notifications@github.com wrote:

Ask MMP to donate counter graphics to VASL?

— Reply to this email directly or view it on GitHub.

uckelman commented 9 years ago

SVG is the best long-term solution.

zgrose commented 9 years ago

Seems like something we get around to when we get rotatable and scalable boards in VASSAL 4? :D

davidsullivan317 commented 9 years ago

Any reason not to release the latest build for testing? We have a couple of small changes left but both are small and can come later.

Anyone want to look #211?

mistertakai commented 9 years ago

MMP has replied and they are unable to donate the graphics to us as they are bound by contract to Hasbro.

bkemp01 commented 9 years ago

I think the key is to use the scan for the artwork only and create the data by hand. There used to be PSD files that had layers to produce the data and you would just add the graphic as another layer.

From: Wargamerx Sent: ‎Wednesday‎, ‎April‎ ‎1‎, ‎2015 ‎7‎:‎50‎ ‎AM To: vasl-developers/vasl

Doesn't help. The existing VASL counters are redrawn. The scans I got looked great at 300 pixels per inch, the problem is they turn to crap when you reduce it to 96 ppi. A 60 by 60 image isn't really sufficient to store the art work and data on a 5/8" counter.

Sent from my iPad

On Mar 28, 2015, at 1:45 PM, Daniel Takai notifications@github.com wrote:

Ask MMP to donate counter graphics to VASL?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

davidsullivan317 commented 9 years ago

I'm finding myself with some free time on my hands this fall, so I'm going to jump start the VASL 6.3 release.

If you have issues you want included please tag them as such. If you'd like to work on an issue please assign it to yourself.

Freddy/Sam/Zoltan - let me know if you're available to help with the coding.

styson commented 9 years ago

I should have some time freeing up this fall as well.

davidsullivan317 commented 8 years ago

I'm clipping through my open issues and Carl is plowing through the HP counter testing. I'm hoping to have a test build of 6.3 available to the unwashed masses in a week or two.

If there's anything you want to see included in the release consider this last call.

BigAl737 commented 8 years ago

Hi David,

Great job and thanks for your untiring efforts!

I will be getting back into map elf work when time permits which should be soon.

I have to confess I’ve recently been enjoying using my free time to play ASL :-)

I would like to see all counters be able to be labelled. If that’s too big a task, then how about starting with the fire lane counters?

Al

On Oct 19, 2015, at 7:10 PM, David Sullivan notifications@github.com wrote:

I'm clipping through my open issues and Carl is plowing through the HP counter testing. I'm hoping to have a test build of 6.3 available to the unwashed masses in a week or two.

If there's anything you want to see included in the release consider this last call.

— Reply to this email directly or view it on GitHub https://github.com/vasl-developers/vasl/issues/208#issuecomment-149404011.

Taschi120 commented 8 years ago

I hope to get #236 done until them, but am not sure I get the configuration thing to work in time. Aside from that, it's pull-ready.

davidsullivan317 commented 8 years ago

@Taschenschieber I believe I merged your branch already.

@BigAl737 Labeling everything shouldn't be that hard - you'll have to find the minimal set of prototypes and add labeling to those. Testing will be the hard part.

Taschi120 commented 8 years ago

@davidsullivan317 You did some time ago, but I've added some more stuff (related to #236) since then. It's all in my own repo over at taschenschieber/vasl. I'll add a new pull request once I'm done.

BigAl737 commented 8 years ago

I’ve updated the VASL files for bd 3 and 19 to include SSOs for OB3 Brasche Encounter and J44 Audacity!

I’m a doofus at git hub. How should I submit these for uploading?

Thanks.

Al

BigAl737 commented 8 years ago

I can do that I think. How much time do I have?

Al

From: David Sullivan Sent: Thursday, October 22, 2015 1:27 PM To: vasl-developers/vasl Cc: Allan Cannamore Subject: Re: [vasl] VASL 6.3 release discussion (#208)

@Taschenschieber I believe I merged your branch already.

@BigAl737 Labeling everything shouldn't be that hard - you'll have to find the minimal set of prototypes and add labeling to those. Testing will be the hard part.

— Reply to this email directly or view it on GitHub.

davidsullivan317 commented 8 years ago

There's no rush. If you send me the files I can upload them to Github for you. -Sully

davidsullivan317 commented 8 years ago

I think that's everything for 6.3. I've created a test build here: https://www.dropbox.com/s/6h0p6716xnx3ts9/vasl-6.3.0-beta1.vmod?dl=0

Please double check your changes and let me know if I should wait to release or not. I'll shoot for this weekend unless I hear otherwise.

BigAl737 commented 8 years ago

Hi David,

I haven’t had a chance to add a label option to RFP markers. I should get this done this weekend if that’s not too late.

Al

From: David Sullivan Sent: Thursday, November 05, 2015 5:03 PM To: vasl-developers/vasl Cc: Allan Cannamore Subject: Re: [vasl] VASL 6.3 release discussion (#208)

I think that's everything for 6.3. I've created a test build here: https://www.dropbox.com/s/6h0p6716xnx3ts9/vasl-6.3.0-beta1.vmod?dl=0

Please double check your changes and let me know if I should wait to release or not. I'll shoot for this weekend unless I hear otherwise.

— Reply to this email directly or view it on GitHub.

davidsullivan317 commented 8 years ago

Sure - no problem. Just use the beta1 module linked above to make your changes.

derimmer commented 8 years ago

All looked good for my stuff.

From: David Sullivan [mailto:notifications@github.com] Sent: Thursday, November 5, 2015 9:04 PM To: vasl-developers/vasl vasl@noreply.github.com Subject: Re: [vasl] VASL 6.3 release discussion (#208)

I think that's everything for 6.3. I've created a test build here: https://www.dropbox.com/s/6h0p6716xnx3ts9/vasl-6.3.0-beta1.vmod?dl=0

Please double check your changes and let me know if I should wait to release or not. I'll shoot for this weekend unless I hear otherwise.

— Reply to this email directly or view it on GitHub https://github.com/vasl-developers/vasl/issues/208#issuecomment-154261907 . https://github.com/notifications/beacon/AHVvIX_hp0BBWwWzvsTIOSMxfsiWKk3Uks5pDAIPgaJpZM4D2HVW.gif

wintrymix commented 8 years ago

So I see three new items that will be visible to the player that would need to be listed in the readme:

What does the user have to do to make the map updates happen? The issue doesn't describe how to make it work.

Is anything missing from the list of special dice rolls?

Are any of the special dice rolls configurable?

wintrymix commented 8 years ago

I did some testing for the special dice rolls:

Special Roll Conditions Result
HoB MC snakes, Rally snakes pass both
Field Promotion Rally snakes, CC snakes pass both
Unlikely Hit TH snakes pass
Unlikely Kill IFT snakes, CC Snakes IFT snakes pass, CC snakes fail
Dud TK boxcars pass
Malf IFT boxcars, 11, 10; TH boxcars, 11, 10, 9 all fail
Multiple Hits doubles TH pass
Cower doubles on IFT pass
Casualty MC boxcars on MC pass
Fate Boxcars on Rally pass
Booby Traps Boxcars on TC fail
Hull/Turret Hit wdr/cdr pass
davidsullivan317 commented 8 years ago

Is is me or does Markdown suck?

Anyway - third time's the charm. Here is the release summary from the release announcement:

Hakkaa Päälle Counters!

Automatic board synchronization!

Other enhancements:

Bug fixes:

Taschi120 commented 8 years ago

I didn't implement Malf and Booby Traps on purpose - malf because it's too variable, booby traps because frankly I think they're too much of a corner case. CC Unlikely Kill is my bad, will try and fix tomorrow. My rule book is several hundred kilometers away, so I'd appreciate if one of you could look up the paragraph number.

If you think malf and BTs should be implemented, I can do that, too.

For reference, you can choose between four levels of notifications - none, Snipers only (mirrors behaviour in 6.2), Starter Kit, Full ASL.

Taschi120 commented 8 years ago

Also, aren't coloured counters in collapsed stacks new as well? I guess they should be mentioned.

wintrymix commented 8 years ago

CC Unlikely Kill is A11.501: "An Original 2 CC DR always results in a chance of success for the attacket even if a CC DRM or small CCV otherwise makes success impossible. Whenever the attacker makes an Original 2 DR, he may roll a third die. IF the subsequent dr is a 1, the vehicle is a buring wreck; if a 2 it is eliminated, if a 3 it is immobilized; otherwise there is no effect. However, regardless of the subsequent dr, if the Original 2 DR would have resulted in an elimination or Immobilization that result still occurs, unless cancelled by an elimination or burning wreck from the subsequent dr.:

wintrymix commented 8 years ago

Where is the level of notification configured? I looked at the Preferences and didn't find it. Is it somewhere else?

wintrymix commented 8 years ago

Understood why you didn't implement Malf and BT. I'm fine with deferring the implementation of these notifications to a future release.

Agreed BT are a rare case (not sure I would call them a corner case, since they are a rule, just an infrequently used rule). Moreover, since the rules allow three levels, the level should probably be configurable. Perhaps that could be implemented in a future release.

Malf might be considered for a future implementation as well. Could the code being used to detect the maps being used be adapted to detect whether a counter is on the board that has a lower breakdown number (or Circled B#)? That would require no intervention from the user. Just a thought. Not saying it's not worth doing if automatic detection is not feasible or is excessive work. In that case, manual configuration is fine. I think these enhancements would add value.

BigAl737 commented 8 years ago

How about adding an additional dust die option (F11.7) to IFT and TH DRs? Something you could click on and off in preferences. I would really appreciate this option.

Less appealing to me but maybe worth consideration would be referencing molotov effects (A22.6111) to the IFT colored dr and TH colored dr for molotov projectors (C13.57).

Allan

From: wintrymix Sent: Saturday, November 07, 2015 3:57 PM To: vasl-developers/vasl Cc: Allan Cannamore Subject: Re: [vasl] VASL 6.3 release discussion (#208)

So I see three new items that will be visible to the player that would need to be listed in the readme:

a.. Updated Finnish counterset (HP counters) b.. Automatic board updates c.. Additional reminders for special dice rolls (DRs) a.. HoB b.. Field Promotion c.. Unlikely Hit/Unlikely Kill d.. Dud e.. Malf f.. Multiple Hits g.. Cower h.. Casualty MC i.. Fate j.. Booby Traps k.. Hull/Turret Hit What does the user have to do to make the map updates happen? The issue doesn't describe how to make it work.

Is anything missing from the list of special dice rolls?

Are any of the special dice rolls configurable?

— Reply to this email directly or view it on GitHub.

wintrymix commented 8 years ago

Those sound like different features. We should probably take them to a different thread.

Taschi120 commented 8 years ago

Right.

Making malf dependent on which counters are on board sounds like an interesting idea, but I'm not sure if it's worth the effort. It's definitely out of scope for 6.3, so let's take it to a new ticket for the 6.4 milestone.

wintrymix commented 8 years ago

Is there a 6.4 or general future features discussion thread somewhere? We can continue the discussion there.

davidsullivan317 commented 8 years ago

Go ahead and create one

davidsullivan317 commented 8 years ago

Hey all - the (hopefully) production build of VASL 6.3 is here: https://www.dropbox.com/s/5694cvjld6lkgge/vasl-6.3.0.vmod?dl=0

Please give it a test drive and make sure everything looks. If so I'd ask Sam to put it up on vasl.info for release. Sam - the release description is above... just one more addition: Label option has been added to all counters.

Thanks all for your help making this happen!

zgrose commented 8 years ago

Did overlay updating mentioned in #205 make it into this build? It appears not.

davidsullivan317 commented 8 years ago

No - just boards for now. I'll add an issue for overlays.

davidsullivan317 commented 8 years ago

The latest build of 6.3 is here: EDIT - see below

please review your changes to make sure they look good.

If there are no issues I'll "release" it for testing.

mistertakai commented 8 years ago

I suggest to call it 6.3.1 as people have already read the announcement on the VASL homepage and downloaded 3.0, to better distinguish the two versions. There was a FB post about it.

uckelman commented 8 years ago

Yes, this. ^^^^

Don't reuse release numbers.

davidsullivan317 commented 8 years ago

The build in my last post was bad. Please use this one: https://www.dropbox.com/s/wzzgex7g0z9al8u/vasl-6.3.0-20151122.vmod?dl=0

Also, if you make any other changes for 6.3 please use the 6.3 branch. I'll merge everything into develop after we're done.

derimmer commented 8 years ago

My stuff seemed to work fine with one exception:

If you set up a board with overlays and open the scenario and then go back to the board selection process (using Pick New Boards for this scenario), the overlays remain in memory even if they are deleted or change position (they will show up in the new and old positions). There is also a similar problem if you close a scenario without saving it and create another immediately thereafter: overlays in the first scenario are retained while the second ones are not added.

I will start to investigate causality but it seems like a collection is not being disposed properly.

Doug

From: David Sullivan [mailto:notifications@github.com] Sent: Sunday, November 22, 2015 10:50 PM To: vasl-developers/vasl vasl@noreply.github.com Cc: Doug Rimmer dougrimmer@rogers.com Subject: Re: [vasl] VASL 6.3 release discussion (#208)

The build in my last post was bad. Please use this one: https://www.dropbox.com/s/wzzgex7g0z9al8u/vasl-6.3.0-20151122.vmod?dl=0

Also, if you make any other changes for 6.3 please use the 6.3 branch. I'll merge everything into develop after we're done.

— Reply to this email directly or view it on GitHub https://github.com/vasl-developers/vasl/issues/208#issuecomment-158847119 . https://github.com/notifications/beacon/AHVvISsbaeJuLghd4RSdOjWCV2Hv6BvWks5pIoRYgaJpZM4D2HVW.gif

derimmer commented 8 years ago

Sully

I did not use the 6.3 branch when I fixed the LOS Overlays bug. Sorry about that, completely forgot!

When I created a push request it let me merge the change into develop which I did.

Doug

From: David Sullivan [mailto:notifications@github.com] Sent: Sunday, November 22, 2015 10:50 PM To: vasl-developers/vasl vasl@noreply.github.com Cc: Doug Rimmer dougrimmer@rogers.com Subject: Re: [vasl] VASL 6.3 release discussion (#208)

The build in my last post was bad. Please use this one: https://www.dropbox.com/s/wzzgex7g0z9al8u/vasl-6.3.0-20151122.vmod?dl=0

Also, if you make any other changes for 6.3 please use the 6.3 branch. I'll merge everything into develop after we're done.

— Reply to this email directly or view it on GitHub https://github.com/vasl-developers/vasl/issues/208#issuecomment-158847119 . https://github.com/notifications/beacon/AHVvISsbaeJuLghd4RSdOjWCV2Hv6BvWks5pIoRYgaJpZM4D2HVW.gif

FredKors commented 8 years ago

Hello!

I’ve just noticed that the CC/Melee counters lost the context menu item that alllow to change them to the Hand-to-Hand version (probably it has been overwrite by the HIP menu command).

Freddy

From: Doug Rimmer Sent: Wednesday, November 25, 2015 9:51 PM To: vasl-developers/vasl Subject: Re: [vasl] VASL 6.3 release discussion (#208)

Sully

I did not use the 6.3 branch when I fixed the LOS Overlays bug. Sorry about that, completely forgot!

When I created a push request it let me merge the change into develop which I did.

Doug

From: David Sullivan [mailto:notifications@github.com] Sent: Sunday, November 22, 2015 10:50 PM To: vasl-developers/vasl vasl@noreply.github.com Cc: Doug Rimmer dougrimmer@rogers.com Subject: Re: [vasl] VASL 6.3 release discussion (#208)

The build in my last post was bad. Please use this one: https://www.dropbox.com/s/wzzgex7g0z9al8u/vasl-6.3.0-20151122.vmod?dl=0

Also, if you make any other changes for 6.3 please use the 6.3 branch. I'll merge everything into develop after we're done.

— Reply to this email directly or view it on GitHub https://github.com/vasl-developers/vasl/issues/208#issuecomment-158847119 . https://github.com/notifications/beacon/AHVvISsbaeJuLghd4RSdOjWCV2Hv6BvWks5pIoRYgaJpZM4D2HVW.gif

— Reply to this email directly or view it on GitHub.

davidsullivan317 commented 8 years ago

So, I have to admit I've been slacking of late. My intent was to get 6.3 out the door months ago, but obviously that didn't happen. Everything is ready to go; the code is in the 6.3 branch: https://github.com/vasl-developers/vasl/tree/release-6.3.0

I'm going out of town for a couple of weeks. If someone wanted to push the release out the door in my absence please feel free to do so. What's left to do is:

davidsullivan317 commented 8 years ago

I fixed a bunch of the outstanding small bugs. Here is a link to the 6.3 release candidate. https://www.dropbox.com/s/n5q60ibuh14x7rw/vasl-6.3.2.vmod?dl=0

If folks would please give it a look - run through the changes that are in 6.3 - I'd appreciate it.

derimmer commented 8 years ago

Hi Sully

Did not check everything but can confirm that automatic board updating is working.

Plus, the overlay stuff that I did seems to be fine.

I did notice that whenever a board is cropped, LOS checking is disabled. Is this what is supposed to happen?

Doug

From: David Sullivan [mailto:notifications@github.com] Sent: Saturday, March 5, 2016 2:26 PM To: vasl-developers/vasl vasl@noreply.github.com Cc: Doug Rimmer dougrimmer@rogers.com Subject: Re: [vasl] VASL 6.3 release discussion (#208)

I fixed a bunch of the outstanding small bugs. Here is a link to the 6.3 release candidate. https://www.dropbox.com/s/n5q60ibuh14x7rw/vasl-6.3.2.vmod?dl=0

If folks would please give it a look - run through the changes that are in 6.3 - I'd appreciate it.

— Reply to this email directly or view it on GitHub https://github.com/vasl-developers/vasl/issues/208#issuecomment-192712935 . https://github.com/notifications/beacon/AHVvId0pwVQWprXnKKmlwls2-NHWQI3Qks5pqdjQgaJpZM4D2HVW.gif