search

vasl-developers / vasl

Virtual Advanced Squad Leader
http://vasl.info/
GNU Lesser General Public License v2.1
66 stars 28 forks source link

bd29 contains psd file #372

Closed jrvjrv closed 7 years ago

jrvjrv commented 7 years ago

At https://raw.githubusercontent.com/vasl-developers/vasl-boards-extensions/master/boards/bd29. This increases its size unnecessarily.

zgrose commented 7 years ago

Should be resolved via vasl-developers/vasl-boards-extensions@698b5e9fc2021b7bc2cef47cd142ab088904a33e

BigAl737 commented 7 years ago

I'm about to update a number of boards for the light woods transform. Would it be worth putting the files that are NOT to be included in the board file in their own folder within the boards main vasl/src folder? Seems this would cut down on these types of errors. Any objections if I do this?

davidsullivan317 commented 7 years ago

We have a piece of code that should do this for us. If we need to add extensions to the exclusion filter let's do that instead. If folks are building boards by some other means please stop.

BigAl737 commented 7 years ago

Guilty, but then I know which files to exclude before building a bd file. I don't know how to use the java board builder code but will gladly do so if someone shows me how. Some board folders contain gifs that have been superseded but retained for reversion purposes. It's not a big deal to include those gifs in the bd file as they aren't that large.

davidsullivan317 commented 7 years ago

No problem. Sorry if I was a little snarky. I thought this was flushed out on the Wiki but it's really not.

I've updated the boards-extensions archive so it matches the source. I did remove an extraneous file from the bdRBv2 folder. If there are still any errors then the source needs to be updated and the board rebuilt.

Here is the IntelliJ run configuration for building the boards from archive. image

Here are the run options: "Usage: BoardBuilder "

is optional and is used to build a single board.
davidsullivan317 commented 7 years ago

The usage didn't display correctly: image

davidsullivan317 commented 7 years ago

Missed the last comment: you don't create a new file to keep the old version of the image. Git will do that for you - if you look at the file history you can access the old version.

derimmer commented 7 years ago

I will update the documentation to include the boardbuilder instructions and also Zoltan's notes on adding board zip files to vasl-website

derimmer commented 7 years ago

Sully, where does the "Usage: BoardBuilder . . . . " go? Where do I put it in the configurations dialogue box?

davidsullivan317 commented 7 years ago

"Usage" describes the options available for the program arguments. The first value is the location of the board src, the second the folder where boards are written, and the third is optional if you want to build one board.

BigAl737 commented 7 years ago

Re closed issue #376, Doug, I followed your directions and was able to run board builder on my MacBook air. Thank you. I know it took a lot of your time to write all those instructions. I'll have to follow them again when I get home and try to run board builder on my home pc, but for now I seem to be good to go. Nicely done!

zgrose commented 7 years ago

Did everyone get the info they needed out of this thread? The issue itself should be resolved.

BigAl737 commented 7 years ago

Got everything I need out of this thread.

zgrose commented 7 years ago

Cool. Closing this to keep the list clean(er).