search

vasl-developers / vasl

Virtual Advanced Squad Leader
http://vasl.info/
GNU Lesser General Public License v2.1
66 stars 28 forks source link

6.4.1 beta1 #423

Closed derimmer closed 7 years ago

derimmer commented 7 years ago

Hi Everyone

I have some code changes that I would like to put out as 6.4.1-beta1. All los stuff: still debugging clipping and flipping (sad face).

Zoltan had suggested adding a number of counter fixes to 6.4.1. Happy to incorporate them. If anyone wants to make a push over the next couple of weeks, that would be great. I would intend to put out beta1 around end of the month.

Any other changes that we should add?

BigAl737 commented 7 years ago

I could do the counter art. I can even make changes to the traits within VASL. However I’ve found that I’m inept at getting the counter loaded into the build file. Let me know if I can still be of assistance.

Allan

From: Doug Rimmer Sent: Friday, July 14, 2017 7:16 AM To: vasl-developers/vasl Cc: Subscribed Subject: [vasl-developers/vasl] 6.4.1 beta1 (#423)

Hi Everyone

I have some code changes that I would like to put out as 6.4.1-beta1. All los stuff: still debugging clipping and flipping (sad face).

Zoltan had suggested adding a number of counter fixes to 6.4.1. Happy to incorporate them. If anyone wants to make a push over the next couple of weeks, that would be great. I would intend to put out beta1 around end of the month.

Any other changes that we should add?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

zgrose commented 7 years ago

Perhaps we can take a quick moment to review the intended workflow for the non-code bits.

If I understand the repo structure and section 6.0 of the GettingStartedWithVASLDevelopment document, the contents of the dist folder are essentially the non-java bits of the vasl.vmod.

So to add a new counter image to the vmod you just add your image to the dist/images folder in the same relative path as you chose for the image in the editor. Additionally, you'll update dist/buildFile with the updated/new counter definitions.

So unless I'm missing some piece of the puzzle:

  1. edit the vasl.vmod with the native tools
  2. extract the buildFile
  3. use a Diff tool of some kind to snip out any unintentional changes
  4. drop new/change counter art into the images folder

So I'll start collecting/doing counter trait changes. If there isn't an open issue for the change I'll create one so it'll be easier to track and make release notes.

derimmer commented 7 years ago

As you will know, the VASL Map is surrounded by a padding of 400 pixels to give room for offboard counters.

The size of the padding seems discretionary. Is there a particular reason for 400 pixels? Have we ever tried/discussed a smaller padding that would allow more of the mapboard to show on screen?

davidsullivan317 commented 7 years ago

We have to pick one value for the padding around the maps and stick to it. It's part of the code and is used to compute the counter locations.

It was changed from 200 to 400 as there wasn't enough room for off-board setup when the counter density got too high.

zgrose commented 7 years ago

Not only off-board setup but tall on-board stacks can push out of the window and counters would become un-selectable without stack wiggling.

derimmer commented 7 years ago

OK. Happy to leave it as is.

From: David Sullivan [mailto:notifications@github.com] Sent: Wednesday, August 2, 2017 8:56 AM To: vasl-developers/vasl vasl@noreply.github.com Cc: Doug Rimmer dougrimmer@rogers.com; Author author@noreply.github.com Subject: Re: [vasl-developers/vasl] 6.4.1 beta1 (#423)

We have to pick one value for the padding around the maps and stick to it. It's part of the code and is used to compute the counter locations.

It was changed from 200 to 400 as there wasn't enough room for off-board setup when the counter density got too high.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vasl-developers/vasl/issues/423#issuecomment-319663683 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHVvIf-MTNhzTMIDWSi3vMEGNmIRhiPnks5sUHHjgaJpZM4OYYTT . https://github.com/notifications/beacon/AHVvIRJQ_RTFLEIBlsrctKPu5P9klZ-zks5sUHHjgaJpZM4OYYTT.gif

derimmer commented 7 years ago

6.4.1-beta1 is now on GS and the Facebook. Great work by Zoltan.