search

vasl-developers / vasl

Virtual Advanced Squad Leader
http://vasl.info/
GNU Lesser General Public License v2.1
66 stars 28 forks source link

German 2-4-8 HIP #58

Open mistertakai opened 10 years ago

mistertakai commented 10 years ago

Art work is visible twice on HIP. Looks like the 468 is shining through.

image

FredKors commented 10 years ago

The 2-4-8 is not the only one, it happens with most of the HS (Axis and Allied).

2014-02-18 23:50 GMT+01:00 Daniel Takai notifications@github.com:

Art work is visible twice on HIP. Looks like the 468 is shining through.

[image: image]https://f.cloud.github.com/assets/3066447/2201431/d3e865da-98ee-11e3-8e26-81a10201f75e.png

Reply to this email directly or view it on GitHubhttps://github.com/vasl-developers/vasl/issues/58 .

davidsullivan317 commented 10 years ago

Strange. The problem exists in 6.0.1. I'm curious when/how it was introduced.

zgrose commented 10 years ago

I think it's any counter with Layers.

FredKors commented 10 years ago

It was already present in 5.9.3.

2014-02-19 0:10 GMT+01:00 Zoltan Grose notifications@github.com:

I think its any counter with Layers.

Reply to this email directly or view it on GitHubhttps://github.com/vasl-developers/vasl/issues/58#issuecomment-35446996 .

davidsullivan317 commented 10 years ago

I found the cause of this bug. The half-squads are not defined correctly. To fix this the following changes need to be made to all half squad (and possibly other pieces?):

Each HS has a squad layer, which is tagged "always active." This needs to be turned off and the SQ/HS toggle added as shown below.

Any of you counter gurus want to take this on? It should be tested and other counters checked for the same side effects.

capture

davidsullivan317 commented 10 years ago

I did some more monkeying around with this bug and the approach outlined above didn't pan out. VASSAL is actually showing the images for multiple layers, which isn't noticed until the HS layer is active at which point two layers are active. Removing the "always active" property causes the squad image to disappear altogether. Opps.

The same behavior occurs is you HIP a broken unit, which is also a layer.

It seems the "right" way to fix this bug is to remove the SQ/HS layer from each piece and use the "replace with other" trait to actually replace the counter. But this causes some weird side effects like selecting the stack when the piece is replaced.

Does anyone know who created the the current SQ/HS counters? Maybe there's an easier way.

davidsullivan317 commented 9 years ago

Not going to make 6.2

JLeslie1004 commented 8 years ago

I will take a look at this.

When I created the extension for the Dinant HASL (in playtest currently), I ran into the same issue because to create new 4-6-8/2-4-8 Assault Engineers for the module I started with the regular 4-6-8Elite/2-4-8Elite counters as a base. I solved the problem but at the moment I can't remember what I did to solve it. I'll figure it out again once I dig into it.

I also noticed that the German 2-3-8AE, 2-3-8Elite, 2-4-8Elite, 2-4-7, 2-3-7, and 2-3-6 HS's all do the squad ghost when HIP'd. I have not looked at other nationalities yet.

In addition (and this probably needs to be a new issue), the 2-3-8AE HS Ctrl-V's to a 5-4-8Elite squad instead of a 5-4-8AE squad. If you take a 5-4-8AE squad and Ctrl-V it, it goes to a 2-3-8AE HS as expected, and the same HS you just Ctrl-V'd goes back to a 5-4-8AE squad as expected.

BigAl737 commented 8 years ago

Been messing with this today and I don't see a cost effective fix. Replace with other is the best option I think but that is very time consuming and would likely induce other errors. The counter replacement system we have in place works very well for BH, ELR, broken, HS/SQ conversions... that this issue seems pretty minor to me. I'd suggest if anyone brings it up again we tell them to use the label option to define the counter. The label text should show clearly when HIP.

derimmer commented 4 years ago

I tested this on October 14, 2020 and the problem still exists exactly as shown in the original email. Low priority on my view but I will leave it on the issues list.

BigAl737 commented 4 years ago

I agree Doug. I can look at this again at some point. Knowing a little more about VASSAL 4 years later there might be some other options:

You maybe could put a back ground colored layer between the icon layers that toggles on/off opposite the HIP activation.

You could make the HIP trait fully transparent and add a semi transparent white layer that toggles on and off with HIP activation.

I think either of those might work, more so the second option. It'd be a time consuming fix though as we're dealing with individual counters and not a prototype.

derimmer commented 4 years ago

Agree with you Al but let me put more stress on my view that this is low priority. LOL

BigAl737 commented 4 years ago

Got it, get it done right away. Understood sir :-)