Closed DragonIsle closed 1 year ago
Thank you for the PR. I'll have a look asap . From a brief look now, is there any validation we can do to the volume strings according to the kubernetes specifications in addition to the non empty check?
Thanks for reviewing! About additional checks, we can add check that mountPath field is actually a file system path (e.g start with /
), don't know what else we can add. As far as I understand, name
and claimName
can be any string
thanks, lgtm, I'll try to release it today
This changes will enable option to add Persistent Volumes to the generated deployment file