Docker image for server?

vassalengine / vassal

VASSAL, the open-source boardgame engine

https://vassalengine.org

GNU Lesser General Public License v2.1

429 stars 103 forks source link

Docker image for server? #10948

Open iaalm opened 2 years ago

iaalm commented 2 years ago

Just want to check whether you have plan to release a docker image for vassal server?

Many people like me don't have reliable connection to the main server. P2P connection is also poor because of multiple layers of NAT. Private server is really the best choice for us. There's little doc about private server but I managed to deploy one for myself. I think having a docker image would help to reduce the pain. I have done a PoC in my repo and released to docker hub. This can easily be controlled via github action. It required me to store my token in github as a secret, so I believe it better be set by someone "own" this repo.

Any idea?

uckelman commented 2 years ago

I'm not clear about what having a Docker container does for you. The Vassal server has one dependency---Java---no configuration, and a single command runs it. What problem is Docker making easier?

iaalm commented 2 years ago

Thank you for your response! Mostly two reason:

Hosting a container is cheaper than a VM most of time.
Anyone who want to run vassal on docker/k8s shouldn't always build container on their own. If you search vassal on docker hub, you do find multiple self-build vassal images. And there're over 4.4k downloads of top 1 image. But this top 1 image hasn't been updated for about 4 years. I build one for myself because it's too old and I don't trust self-build images.

I just think an "offical" image is much better than "third-party" one.

iaalm commented 2 years ago

@uckelman any comments?

uckelman commented 2 years ago

No comments. I haven't gotten back to this.