search

vassalengine / vassal

VASSAL, the open-source boardgame engine
https://vassalengine.org
GNU Lesser General Public License v2.1
439 stars 105 forks source link

Save expanded status #4499

Open uckelman opened 3 years ago

uckelman commented 3 years ago
Bugzilla
ID BZ1906
Reported 2008-10-12 03:18:00 +0200
Modified 2020-06-22 00:12:35 +0200
Product VASSAL
Component Unknown
Version unspecified
Platform All
OS All
Status NEW
Resolution None
Priority medium
Severity enhancement
Milestone ---
Reporter Joel Uckelman
Assignee Bugs

Joel Uckelman 2010-08-25 14:35:37 +0200

---- Reported by pgaskill 2008-10-12 15:18 ----

Please enable saving of the expanded status of stacks of pieces, so if the file was saved with a stack in the expanded state, the stack will still be expanded when the file is reopened.

--- Bug imported by uckelman@nomic.net 2010-08-25 14:35 MST  ---

This bug was previously known as _bug_ 2161656 at http://www.vassalengine.org/trackershow_bug.cgi?id=2161656

The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: uckelman@nomic.net.
   Previous reporter was pgaskill.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, uckelman@nomic.net.
   Previous assignee is unknown.
Missing Resolution. Setting status to NEW
Unknown resolution "".
   Setting resolution to MOVED
Cattlesquat commented 3 years ago

I actually sat down and wrote code to do this (by encoding expansion into the stack's "state"), and then realized that it would end up sending stack expanded changes in multiplayer games too (e.g. you'd end up getting stack expansions when your opponent expanded stacks), which seems definitely-not-wanted to me.

Expanded flag is really more of a "local visual cue" and so if we were going to save stuff like that it would unfortunately have to go in some whole different section of stuff.