vassalengine / vassal

VASSAL, the open-source boardgame engine
https://vassalengine.org
GNU Lesser General Public License v2.1
418 stars 99 forks source link

Left and right ALT keys treated as separate modifier keys (but not SHOWN as separate) #9418

Open uckelman opened 3 years ago

uckelman commented 3 years ago
Bugzilla
ID BZ13643
Reported 2020-11-15 20:10:00 +0100
Modified 2020-12-05 22:01:50 +0100
Product VASSAL
Component Unknown
Version 3.4.8
Platform PC
OS Windows
Status NEW
Resolution None
Priority unspecified
Severity normal
Milestone ---
Reporter Mike Vanleeuwen
Assignee Bugs
CC flint.1b@gmail.com

Mike Vanleeuwen 2020-11-15 20:10:19 +0100

When creating (and using) a Key Command, the left and right ALT keys are treated as unique modifier keys. I.E.  Left_ALT+ is unique from Right_ALT+. 

To reproduce, 
 add piece to at-start stack.
 add dynamic property to piece.
 add key command "testA" defined using LEFT_Alt+F1 to perform change of your choice (e.g. add 1 to numeric)
 add second key command  "testB" defined using RIGHT_Alt+F2 to perform different change of your choice (e.g subtract 1 from numeric)
 add text label to piece to display dynamic property
 run module

Expected Results:
 LEFT_Alt+F1 and RIGHT_Alt+F1 trigger action defined for testA.
 LEFT_Alt+F2 and RIGHT_Alt+F2 trigger action defined for testB.

Actual Results:
 only LEFT_Alt+F1 will trigger action defined for testA.
 only RIGHT_Alt+F2 will trigger action defined for testB.

Verified that this was not the case in 3.2.17.

Occurs in 3.4.7 (which is first instance of 3.4.x I installed) and 3.4.8.
Occurs in VASSAL-3.4.9-SNAPSHOT-847024810 (windows-64 build)

Flint 2020-12-03 10:23:36 +0100

This should be the intended behavior.

As the name already suggests, Left_ALT is not the same as Right_ALT, they are unique modifier keys. On some international keyboards they do very different things.

Mike Vanleeuwen 2020-12-05 22:01:50 +0100

Flint,
If Vassal's intended behaviour is to treat the left and right alt keys as separate modifiers, then the interface needs to reflect this. It should display "Right Alt" and "Left Alt" and not just "Alt".
Cattlesquat commented 2 years ago

Emailed user

riverwanderer commented 2 years ago

I also reported this Right/Left Alt key issue (Option key on Mac), buried in the general Mac keyboard issues, though this one looks like it is cross-platform. Let me know if I can help @Cattlesquat.