CLI search for cpu_ram seems bugged

vast-ai / vast-python

Vast.ai python and cli api client

MIT License

117 stars 44 forks source link

CLI search for cpu_ram seems bugged #49

Closed Brodski closed 1 year ago

Brodski commented 1 year ago

Hi all,

The cpu_ram field seems bugged when searching for offers. I think there is a conversion bug?

As you can see in the screen shot, I have two searches. The second search uses cpu_ram and I get unexpected results.

Based off of this https://github.com/vast-ai/vast-python/blob/389bfaac68cf8c15b5146a5aba0fca03a7b9c309/vast.py#LL1095C16-L1095C16

nathanneuro commented 1 year ago

Hi Brodski, could you give a little more detail about the issue you are seeing with the cpu_ram? the search field description is "cpu_ram: float system RAM in gigabytes" your search specified "cpu_ram > 16" and the search results all seem to have over 16 GB of RAM 128.9, 128.9, 96.3, 64.4, 64.4 (both the query and the results are in GB)

Brodski commented 1 year ago

Hello @nathanneuro,

My bad, I should have provided more detail in the post.

So yes all search results are over 16 GB, but there should be more, looks like I am missing a few. In the screenshot, I marked the offers in the first query.

we are missing two 32.0 GB RAM offers
Missing a 64.5 GB RAM offer. There are 3 total, but only 2 showed.

Screenshot 2023-06-10 172034