vast-engineering / jquery-popup-overlay

jQuery plugin for responsive and accessible modal windows and tooltips
https://dev.vast.com/jquery-popup-overlay
MIT License
510 stars 138 forks source link

Checks for undefined, null - related #30 #70

Closed melkybee closed 7 years ago

melkybee commented 7 years ago

This happens after closing the popup in Chrome Version 57, 64-bit - Uncaught TypeError: Cannot read property 'blur' of undefined (line 709)

After making the above fix, this happens after closing the popup in IE8, Windows 7 - 'openelement' is null or not an object (line 676)

This fix checks for these elements. Related #30.

vladimirsiljkovic commented 7 years ago

Thanks for fixing, Mellisa.

I couldn't reproduce this myself in Chrome Version 57 using the demo page, but since the fix is just extra checking for safety and other people reported the same error in #30 I think it should be safe to merge it.