search

vast-lib / tinyVAST

Expressive interface for multivariate spatio-temporal models
https://vast-lib.github.io/tinyVAST/
GNU General Public License v3.0
12 stars 2 forks source link

Fix some unit tests #26

Closed seananderson closed 10 months ago

seananderson commented 10 months ago

Suppress some warnings. Make sure tests aren't missing an expectation. Make sure packages loaded. Needed for coverage checks (although there might be other issues too).

James-Thorson-NOAA commented 10 months ago

Thanks Sean!

After thinking a bit, I'm gonna instead do a PR from your branch into my current branch add_header, resolve the conflicts by prioritizing your versions in those files that you changed, and see if that still passes checks. Feel free to tell me if you see a better way to do this, I'm still learning about how best to use github collaboratively with multiple developers.

James-Thorson-NOAA commented 10 months ago

I merged this to add_header which is my current dev branch. I'm trying to sort the stream-network example, which is causing the pkgdown to fail on Actions, although it runs locally. Anyway, I'm gonna close this for now, but the changes will go to main when I merge add_header