search

vast-lib / tinyVAST

Expressive interface for multivariate spatio-temporal models
https://vast-lib.github.io/tinyVAST/
GNU General Public License v3.0
10 stars 2 forks source link

Update delta-model family functions #34

Closed James-Thorson-NOAA closed 5 months ago

James-Thorson-NOAA commented 8 months ago

Collapse delta_gamma and delta_poisson_link_gamma etc, following lead of sdmTMB

seananderson commented 8 months ago

I did this over in sdmTMB in this branch: https://github.com/pbs-assess/sdmTMB/tree/newdeltas

See the last commit.

I'm just waiting for all the checks to run before merging into main. I also removed the hardwiring of the delta family links. Probably simplest just to import/re-export these.

seananderson commented 8 months ago

I now realize the 'clean names' still have hardwired links, but I'll make an issue and deal with that later. It's slightly tricky because people can use "log" or log etc.

seananderson commented 8 months ago

This has been merged into the main sdmTMB branch including a fix for the 'clean name' links. I suppose we'll have to copy the code into tinyVAST for now because the CRAN version of sdmTMB doesn't have the new function arguments.

James-Thorson-NOAA commented 7 months ago

I see that the latest sdmTMB release on github and CRAN 0.4.2 is about a month old. do you anticipate doing a CRAN release with the updated delta-model stuff soon (in which case I'll switch to using exported functions from sdmTMB for tinyVAST family functions), or any insight on timeline?

seananderson commented 7 months ago

I should get a new CRAN release up shortly. For one, those new delta families affect examples in the preprint and submitted revision. Maybe over the next couple weeks? I'll post a release checklist as an issue.

James-Thorson-NOAA commented 5 months ago

now done, thanks Sean :)