search

vastec / ember-unused-components

Search for unused components in your Ember project
51 stars 12 forks source link

Adds process exit code so that we can use this in CI #31

Closed Duder-onomy closed 5 years ago

Duder-onomy commented 5 years ago

This should supersede and close #30

Duder-onomy commented 5 years ago

I can confirm that this correctly fails tests in CircleCI: Untitled drawing

tniezurawski commented 5 years ago

Nice @Duder-onomy! Thanks for that!

Could you add a paragraph to README.md about running it on CI? Just a simple example of how you've added it to your pipeline?

Duder-onomy commented 5 years ago

@tniezurawski I changed my mind about having this lib check if in CI directly in favor of a config variable / cli argument.

It seemed to make more sense that the person should be able to opt into this behavior directly. The whole 'if we are in ci' business is not the concern of this lib.

I added that support and updated the readme.

There is a diff in the package-lock.json that I did not intend. Simply running npm install creates that diff. I see there is a yarn.lock in the directory as well. Might make sense to switch to yarn until npm install creates deterministic builds.

tniezurawski commented 5 years ago

Great stuff @Duder-onomy! Thanks for the work you've put into this 🙌

tniezurawski commented 5 years ago

Released with 1.1.0 version.