fix refactoring typo that prevents correct estimates in diff module

vastgroup / vast-tools

A toolset for profiling alternative splicing events in RNA-Seq data.

MIT License

77 stars 28 forks source link

fix refactoring typo that prevents correct estimates in diff module #116

Closed hmehlan closed 10 months ago

hmehlan commented 10 months ago

this refactoring typo prevents the fitting of a new posterior beta distribution using maximum-likelihood estimation with fitdistr in function diffBeta as no valid initial values are given
the calculation now takes about 10 times longer

UBrau commented 10 months ago

The change fixed a bug that resulted in failure to fit a joint beta distribution over all replicates of a sample type, whereupon we fell back to pooling samples from beta distributions based on inclusion and exclusion read counts of separate replicates (which generally happened for PSI close to 0 or 100). While we like the intended behaviour for conceptual reasons, the fix has now resulted in increased compute time.