vasturiano / globe.gl

UI component for Globe Data Visualization using ThreeJS/WebGL
https://vasturiano.github.io/globe.gl/example/world-population/
MIT License
1.97k stars 293 forks source link

onLabelClick() not doing anything #122

Closed GirkovArpa closed 1 year ago

GirkovArpa commented 1 year ago

I hope you will accept my collaborator invite, and can check out why onLabelClick() is not doing anything in that repo.

GirkovArpa commented 1 year ago

So I was using FlyControls and they seemed to be clashing with the default OrbitControls. controls().enabled = false and controls().dispose() didn't seem to do anything at all, so I was using .pauseAnimation() but unfortunately this also paused detecting label click events.

I solved this in the end with .controls().update = () => {}, overriding the update function of the default controls to a noop.