vasturiano / globe.gl

UI component for Globe Data Visualization using ThreeJS/WebGL
https://vasturiano.github.io/globe.gl/example/world-population/
MIT License
2.03k stars 301 forks source link

[Bug?] polygonCapCurvatureResolution won't update after creation #18

Closed lslzl3000 closed 4 years ago

lslzl3000 commented 4 years ago

Describe the bug The new polygonCapCurvatureResolution method only apples in the first creation process. After that, the loop still running with new data or changes, but the polygon won't update.

To Reproduce Steps to reproduce the behavior:

  1. Init polygons with polygonCapCurvatureResolution(d=> d.active ? 1 : 10), it works fine
  2. Change the active or reset polygonsData
  3. the polygonCapCurvatureResolution loop will re-run, but the polygon won't change

Expected behavior polygonCapCurvatureResolution will change the polygon layers after new loop

lslzl3000 commented 4 years ago

By the way, as #17 suggestion, can we apply a filter for all accessor functions to reduce the loop? In most of cases, we only update one data at a time, so loop all of them is not a efficient way, especially for functions related to geometry updating process

vasturiano commented 4 years ago

Thanks @lslzl3000. Should be fixed in v2.12.2.