search

vasturiano / globe.gl

UI component for Globe Data Visualization using ThreeJS/WebGL
https://vasturiano.github.io/globe.gl/example/world-population/
MIT License
2.03k stars 301 forks source link

pointsData([]) cannot clear points with pointsMerge(true) #19

Closed lslzl3000 closed 4 years ago

lslzl3000 commented 4 years ago

Describe the bug With enable pointsMerge, the pointsData([]) won't able to empty points

To Reproduce Steps to reproduce the behavior:

  1. add some points with pointsData([...])
  2. also set pointsMerge(true)
  3. try to empty points with pointsData([])
  4. then you will see no points removed

Expected behavior All points should be removed

I dont't test hexBinMerge yet, it may share the same problem

vasturiano commented 4 years ago

Thanks for reporting @lslzl3000.

There was a bug with the cleanup of the scene after updating when using merge geometries. And you're right that it was happening with the hexBin layer too.

Both issues are now fixed in v2.12.3. 👍