search

vasturiano / three-geojson-geometry

ThreeJS geometry to stroke GeoJSON objects on a sphere
https://vasturiano.github.io/three-geojson-geometry/example/countries/
MIT License
67 stars 15 forks source link

feature/typeof-window #6

Closed PaulieScanlon closed 3 years ago

PaulieScanlon commented 3 years ago

Hey, i've added typeof window !== 'undefined' to index.js, i think this will resolve any SSR framework errors but would you mind investigating?

Thanks in advance

Paul

PaulieScanlon commented 3 years ago

I've created an issue for this PR which can be seen here issues/5

vasturiano commented 3 years ago

@PaulieScanlon thanks for your PR! I think this change makes sense. However, I see a lot of unrelated code changes in the PR. Could you update it so that it includes only the relevant small section?

PaulieScanlon commented 3 years ago

@vasturiano Hey, ty for taking a lot.

Blast!

I think those other changes are my prettier formatter messing with us. Lemme see if i can disable that.

Were you ok with the inclusion of the standard GitHub node .gitignore?

PaulieScanlon commented 3 years ago

@vasturiano Hey, ok i think i've got it this time. Not 100% sure what your tabs or spaces settings were by i disabled my prettier extension. There's still a lot of lines changed but most are because everything's now indented by one because it's nested in the if

Lemme know what you think!

Ty!

vasturiano commented 3 years ago

@PaulieScanlon I still see many changes in the code. Would you mind making it so only the typeof window !== 'undefined' is added and nothing else? Also, to keep it on topic, please don't include any other unrelated changes like the .gitignore file.

PaulieScanlon commented 3 years ago

@vasturiano hey! sure thing, Just pushed again. This has a minimal amount, which should make it easier to see what i've added.

Thanks for your time!

vasturiano commented 3 years ago

Thx @PaulieScanlon!