Styled tables in CSS - Githubissues

vasu-gondaliya / rubiks-cube

A Rubik's Cube Visualizer with face turns, cube rotations, scramble generator, flat view of cube and cube animation

https://vasu-gondaliya.github.io/rubiks-cube/

MIT License

28 stars 30 forks source link

Styled tables in CSS #15

Closed 96RadhikaJadhav closed 1 month ago

96RadhikaJadhav commented 3 years ago

This PR will resolve issue #5 .

96RadhikaJadhav commented 3 years ago

@vasu-gondaliya I have styled both tables on the page, so it will look the same. Could you please review it?

vasu-gondaliya commented 3 years ago

@96RadhikaJadhav the tables look good. But I think it will look better if the colour scheme is dark based as the background is of that type too. What do you think?

96RadhikaJadhav commented 3 years ago

@96RadhikaJadhav the tables look good. But I think it will look better if the colour scheme is dark based as the background is of that type too. What do you think?

@vasu-gondaliya If we make it dark it will look like no changes have been done. But if you feel it will look good in dark then I can make the changes.

vasu-gondaliya commented 3 years ago

@96RadhikaJadhav Something like this would look good. Or else you suggest some other style.

96RadhikaJadhav commented 3 years ago

See if this is looking good to you. Please let me know if you want it to change.

vasu-gondaliya commented 3 years ago

@96RadhikaJadhav Try the coloured one, I think it would look good. And first update the fork as many changes have been made.

96RadhikaJadhav commented 3 years ago

@vasu-gondaliya I made the changes. Can you please check now?

vasu-gondaliya commented 3 years ago

I saw the added css but I am not able to see the coloured rows. I think you need to remove the background color properties of "td" elements. And can you use more vibrant colours? Check it out here https://www.schemecolor.com/tag/rainbow?trend . And remove the thick border.

vasu-gondaliya commented 1 month ago

Thank you everyone for the contributions!