vasu-gondaliya / rubiks-cube

A Rubik's Cube Visualizer with face turns, cube rotations, scramble generator, flat view of cube and cube animation
https://vasu-gondaliya.github.io/rubiks-cube/
MIT License
28 stars 30 forks source link

New Favicon #27

Closed bmento closed 1 month ago

bmento commented 2 years ago

I noticed the favicon on this project contains colors that aren't normally or a Rubix cube so I decided to make a new one with only valid colors

YodaRobot commented 2 years ago

@bmento could you attach the file? That would probably be very helpful. Thanks.

Vedant-Manjrekar commented 2 years ago

Hii @vasu-gondaliya @bmento, i would like to work on this issue. Is this image fine for favicon.

Screenshot 2022-09-29 at 4 21 24 PM
Saucistophe commented 2 years ago

Thanks @Vedant-Manjrekar , I took the liberty to use your image and remove the background.

vasu-gondaliya commented 1 month ago

Apologies for the delay in addressing this issue. Any favicon design needs to be simple to reflect the essence of the project/website and need not be complex. For that reason I had chosen a simple 3X3 square grid as the favicon.

Regarding @bmento issue as to why the favicon "contains colors that aren't normally or a Rubix cube", I had the option to select some combination of the six valid colors and make the favicon, but instead I took some creative liberty and chose three other colors that I liked. So this doesn't seem like an issue at all.

Thanks for taking out time and contributing to the project!

Saucistophe commented 1 month ago

Thanks for taking the time to apologize, I remember I was pissed because my PRs for Hacktoberfest 2021 were merged in September 2022, so I thought I'd try again and see how long it would take this time. The answer is two years, apparently!

vasu-gondaliya commented 1 month ago

I completely understand your frustration. I’ve experienced similar delays when I was more active on GitHub and contributing to various projects. It's often the case that many project maintainers aren't as active or may be tied up with professional work.