search

vasyabigi / angular-nouislider

Simple angular directive for jquery nouislider plugin
http://vasyabigi.github.io/angular-nouislider/
MIT License
84 stars 53 forks source link

ngFrom and ngTo? #15

Open mg1075 opened 10 years ago

mg1075 commented 10 years ago

Unless I am completely missing something, is it not a bit against best practice to use ngFrom and ngTo as attribute names?

What if these become standards in some future version of angular for unrelated to the intention of them in this directive?

https://docs.angularjs.org/guide/directive

Best Practice: In order to avoid collisions with some future standard, it's best to prefix your own directive names. For instance, if you created a directive, it would be problematic if HTML7 introduced the same element. A two or three letter prefix (e.g. btfCarousel) works well. Similarly, do not prefix your own directives with ng or they might conflict with directives included in a future version of Angular.