Open weberml2 opened 9 years ago
Solid work! Thanks for doing this.
Noticed some missing parts when comparing your PR with the Slick documentation and source code:
// edgeFriction
// mobileFirst
// respondTo
// rows
// slidesPerRow
// pauseOnDotsHover
// onEdge
// onSwipe
// ??
// onDestroy
// onBreakpoint
Check both slick instantiation and the scope
var, as they both need slightly different additions to the missing bits listed above.
Also, I could not find any mention of a callback named breakpoint
or destroy
via the Slick docs/source code.
Also, I could not find any mention of a callback named breakpoint or destroy via the Slick docs/source code.
Ok, found reference to breakpoint
and destroy
on this page.
Looks like the docs here are not up-to-date with the GitHub repo's readme.
Sounds good, I'll take another crack at it, and will probably need to rev the Slick dep in situ to make sure the documentation I am using matches the current Slick
Sounds good, I'll take another crack at it
Awesome! Thanks @weberml2 :+1:
I'll double-check your work later today (first glance, it's looking good).
rev the Slick dep in situ to make sure the documentation I am using matches the current Slick
Ahh, good point. I overlooked that in my initial comment.
So, I'm hoping we can get @vasyabigi to merge. Your fixes should help to close/fix several other issue from what I have seen/read.
Is @vasyabigi still alive ? This library hasn't been updated for a will now ...
@nicolas-besnard Not sure. Looks like he needs some help maintaining.
initial-slide doesn't seem to work for me. It just super fly aways on first "next". See http://cl.ly/1M2c2n1b2u30 Previous slide does work though. Any idea for this? Same for latest original vasyabigi repo
The example is using
<slick class="slider single-item" current-index="index" responsive="breakpoints" initial-slide="1" >
<div ng-repeat="i in [1,2,3,4,5]"><h3>{{ i }}</h3></div>
<p>Current index: {{ index }}</p>
</slick>
I've emailed @vasyabigi to check on him and see if he is still maintaining this repo. If he is not; I think the best thing would be to make a new repo and add the code to it, and not fork it, because forking just hides code on GitHub.
@idreeshaddad have you tried this repo - https://github.com/devmark/angular-slick-carousel ? seems like another slick angular wrapper, more maintained and up-to-date
@avivr Yeah I've tried it and I personally didn't like it. This one has more potential. There are lots of good pull requests, I sure hope this gets maintained.
SO MUCH POTENTIAL. Such a shame @vasyabigi has neglected the plugin :(
Breaking change-- bind to callback function in order to pass event parameters back to controller. Supersedes PR #100