vatertime / minecraft-spot-pricing

Cloudformation template to deploy a Minecraft server
MIT License
140 stars 84 forks source link

Added an ASG Capacity Provider, linking the ASG with the ECS Service #18

Closed javabrett closed 2 years ago

javabrett commented 2 years ago

Changes

Desired Outcome

This isn't a huge benefit on its own, but it seems to deploy the ASG with the capacity provider as-designed. It will also allow the scale of the ECS Service itself to control the ASG, which is currently running as capacity only, without scaling rules.

[1]: Originally I thought to only link the capacity provider to the cluster, and allow the service to pick it up by-default, which is what the documentation suggests should happen. This was not working for me - I suspected a timing issue or need for an explicit DependsOn in the cf template - instead I elected to make the service/capacity-provider link explicit, which is probably better anyway.