Goreleaser is failing since vm ISO support was merged

vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform

MIT License

150 stars 32 forks source link

Goreleaser is failing since vm ISO support was merged #130

Closed ddelnano closed 3 years ago

ddelnano commented 3 years ago

I didn't realize this until #128 was merged but the integer contsants used in that branch are causing overflows on i386 arches

   ⨯ release failed after 15.96s error=failed to build for linux_arm_6: # github.com/ddelnano/terraform-provider-xenorchestra/client
client/vm.go:373:10: constant 2147483648 overflows int
client/vm.go:386:8: constant 16106127360 overflows int
client/vm.go:393:8: constant 16106127360 overflows int

This will need to be fixed before the next release can be made

ddelnano commented 3 years ago

I updated the goreleaser config file to ignore the 386 and ARM 6 architectures (see a71e0a4bf40c1d8d53748c3b2f3e0931de50a915, fb8cfe3afc0df101aca6d443955667d66a358f9e and 270d077d72c0483f0b95de985345b00f156f373f). Since these are 32bit it's unlikely that someone was using these (given the integers needed to create real VMs would be > 4 GB).