Closed ddelnano closed 3 years ago
@gohumble I made additions on top of your changes in #142. The largest changes were around improving the acceptance tests to verify that the sorting works.
This should be done aside from the docs that need to be written but I'd appreciate it if you could give this a review.
sorry for replying bit late. tested your changes in my home lab. everything is still looking good :)
Is it worth doing a release with these changes in?
@brd I will. I'm trying to merge #144 before making the next release.
@brd it's now available in v0.19.0 of the provider
This is a continuation of #120
Todo
TestAccXenorchestraDataSource_host
test (the requiredid
attribute is causing it to fail)xoa/data_source_host.go
andxoa/host.go
TestGetSortedHosts
and the acceptance tests (testing that sorting works, etc) - Verify that number of hosts in acceptance test is greater than 1 and create a newTestCheckTypeListAttrSorted
to validate the sorting is correctmake testacc
passes (currently all new tests are passing)