Prevent halted VMs from causing diff on network and disk attachment attributes

vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform

MIT License

150 stars 33 forks source link

Prevent halted VMs from causing diff on network and disk attachment attributes #152

Closed ddelnano closed 3 years ago

ddelnano commented 3 years ago

This addresses #99.

Testing

[x] New test verifies new functionality
[x] make testacc passes
- [x] Fix issues with attach and disconnect vif and disk tests
- [x] Fix race conditions for the TestAccXenorchestraDataSource_cloudConfig, TestAccXenorchestraDataSource_resourceSet, TestAccXenorchestraDataSource_user and TestAccXenorchestraDataSource_read tests

ddelnano commented 3 years ago

Most of the tests are passing, but the implementation seems to be causing failures for the existing attach and detach vif and disk VM tests.

ddelnano commented 3 years ago

TestAccXenorchestraVm_createWithShorterResourceTimeout seems to consistently fail, which seems to be a regression that exists in master. I'll open up a GitHub issue for this but it shouldn't block merging this change.