search

vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform
MIT License
150 stars 32 forks source link

xenorchestra_pif data source improvement #16

Closed m0ps closed 5 years ago

m0ps commented 5 years ago

You implemented figuring out of UUID by device name, but... if we have a lot of pifs with device "eth1" but with different VLAN, I suppose that it will work incorrectly. It needs to be specified in another way. Maybe in addition to device, VLAN should be specified.

ddelnano commented 5 years ago

Can you show me a pif-list on your Xen server or what the objects look like in the XO api?

m0ps commented 5 years ago

Sure:

[root@idmbs-hv002 ~]# xe pif-list
uuid ( RO)                  : e34c0912-92f0-59c7-b2d7-a568ed54e823
                device ( RO): eth1
    currently-attached ( RO): true
                  VLAN ( RO): -1
          network-uuid ( RO): a75d0c30-37f0-0fd1-951b-33a9d7b08bae

uuid ( RO)                  : f14bd3e5-5953-6ceb-7288-82d5bf90166d
                device ( RO): idrac
    currently-attached ( RO): false
                  VLAN ( RO): -1
          network-uuid ( RO): e7ef5216-c6f1-25b5-cd40-dc3b344d86d0

uuid ( RO)                  : 82f5ae10-ce91-69ea-0630-ed3ccf2d621b
                device ( RO): eth3
    currently-attached ( RO): false
                  VLAN ( RO): -1
          network-uuid ( RO): e7148e30-2138-9418-071f-8e59588b6f6a

uuid ( RO)                  : 303becfb-49be-ac26-1fee-f8feaf5939e9
                device ( RO): eth0
    currently-attached ( RO): true
                  VLAN ( RO): -1
          network-uuid ( RO): d4c6070d-e4a0-6440-cba7-accaf5bc3d54

uuid ( RO)                  : 858b1499-bf12-80a7-70f1-6c5b198e826f
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): 1244
          network-uuid ( RO): 6301ada5-8df7-6597-6477-28c085648709

uuid ( RO)                  : c68fa80a-313c-c205-8a2f-712f2ed45e53
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): 1245
          network-uuid ( RO): 44eb5c1e-158e-3b23-61fd-00598eab3450

uuid ( RO)                  : b17c9caa-2b35-320a-c644-5ae1ac449b80
                device ( RO): eth0
    currently-attached ( RO): true
                  VLAN ( RO): 1430
          network-uuid ( RO): 6c251f3e-a706-320f-f022-ad66507fe83e

uuid ( RO)                  : 0c3388d6-9a89-8157-4c2b-5c93f769a67b
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): 1231
          network-uuid ( RO): f017f304-b8cb-9d36-ef17-fae0c7c24492

uuid ( RO)                  : 50cb05d4-fc97-b426-cffb-63085fc69cf5
                device ( RO): eth2
    currently-attached ( RO): false
                  VLAN ( RO): -1
          network-uuid ( RO): f519f055-5ff0-ecb1-2a0e-73d19f35915c

uuid ( RO)                  : 38535ebc-775b-ed31-e3d1-37152e390b80
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): 1236
          network-uuid ( RO): e7c34b9d-9fee-098f-dbc1-dcf36a1555a7

uuid ( RO)                  : 730e63f5-2fc4-796d-4365-ed166e40a329
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): -1
          network-uuid ( RO): 2f386d3c-cb03-73f1-fea6-0833c13c87d4

uuid ( RO)                  : 8c12bf46-6c4c-43e8-dd3f-b9cdacdd69f9
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): 1248
          network-uuid ( RO): d7119536-4d27-69e6-5bcb-b9d8495775ee
ddelnano commented 5 years ago

@m0ps I believe #17 should fix your issues (vlan is now required for the pif data source). Please reopen this issue if that is not the case.