search

vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform
MIT License
150 stars 33 forks source link

extend host data source variables #160

Closed gohumble closed 3 years ago

gohumble commented 3 years ago

In preparation to the vms data source, I've extended the variables from host data sources to include cpu and memory information.

I was not able to wrap the memory info into a map like done with cpu info in hostCpuInfoToMapList() function. Therefore, i added memory and memory_usage as own variables.

ddelnano commented 3 years ago

A few minor comments but overall looks good :+1:

gohumble commented 3 years ago

Added all changes needed. Thanks for the nice feedback. Did manage to finally run and pass the acceptance tests for these data sources.

ddelnano commented 3 years ago

One more comment about using hostCpuInfoToMapList in another spot and then this is ready to merge 👍

gohumble commented 3 years ago

Was not able to apply that patch using git apply. Did add the changes manually. Hope I did not miss smth.

ddelnano commented 3 years ago

yep, lgtm!