search

vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform
MIT License
150 stars 33 forks source link

Update vms data source memory_max #166

Closed gohumble closed 3 years ago

gohumble commented 3 years ago

After doing some more testing, I noticed that the new vms data source's memory_max attribute was probably set wrong.

vm.Memory.Static[1] is also used to create and update the vms.

Unfortunately, I did not notice that vm.Memory.Size and vm.Memory.Static[1] have slightly different values. Sorry for that.

ddelnano commented 3 years ago

The provider's usage of vm.Memory.Static may need to be updated in the future. However, I agree that we should remain consistent until that gets figured out.

Thanks for catching this :+1: