Rebased upstream xo sdk

vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform

MIT License

150 stars 33 forks source link

Rebased upstream xo sdk #176

Closed ddelnano closed 2 years ago

ddelnano commented 2 years ago

This is a rebased version of #174 due to #175. It was tested locally with https://github.com/vatesfr/xo-sdk-go/pull/4.

Todo

[x] Update go.mod file once https://github.com/vatesfr/xo-sdk-go/pull/4 is merged

ddelnano commented 2 years ago

@ringods sorry that your change was made just as I needed to revert some code in the xo client. Please see the related review, but it's probably easiest for us to use this branch (since yours needed a rebase).

ringods commented 2 years ago

@ddelnano no problem. I just approved and merged your PR in the XO sdk repo.

ddelnano commented 2 years ago

I'll run the terraform acceptance tests once more to verify this is good and then I'll merge this.

ddelnano commented 2 years ago

Closing this due to the conversation on https://github.com/vatesfr/xo-sdk-go/pull/5. I'll happily revisit it and upstream changes there if need be.