search

vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform
MIT License
150 stars 33 forks source link

Upstream `gotestsum` changes used by acc test suite #218

Closed ddelnano closed 9 months ago

ddelnano commented 1 year ago

In #188, I decided to modify gotestsum in order to allow it to rerun tests that have panic'ed (https://github.com/ddelnano/gotestsum/commit/8c70ff05e83bc93e5e042151a4d25343f1dfe4f8). This is common in the acceptance test suite because many of the VM tests take a long time to run and result in flaky builds due to the timeouts.

We should upstream these changes so that it isn't required to use my fork of the gotestsum repository long term. From my work in this space, gotestsum has a history of dealing with go's timeout panic behavior (https://github.com/gotestyourself/gotestsum/pull/192, https://github.com/golang/go/issues/45508, https://github.com/golang/go/issues/38382). The maintainer of the project has disabled this behavior, but I'm hopeful it would be accepted behind a runtime toggle.

ddelnano commented 1 year ago

I've created an issue to inquire if this contribution would be accepted (https://github.com/gotestyourself/gotestsum/issues/290)

ddelnano commented 9 months ago

This is no longer needed.