vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform
MIT License
150 stars 33 forks source link

Improve XO client's handling of VM shutdown #221

Closed ddelnano closed 1 year ago

ddelnano commented 1 year ago

This addresses #220 and is a prerequisite to completing #212. See #220 for more details.

Testing

[ ... ]

resource_xenorchestra_vm_test.go:1397: failed to halt VM with error: jsonrpc2: code 14 message: VM lacks feature : {"objectId":"195f07f5-c699-a270-3a31-a9eaafc54af3"}

--- FAIL: TestAccXenorchestraVm_diskAndNetworkAttachmentIgnoredWhenHalted (49.81s)

- [x] Verified that the `TestAccXenorchestraVm_diskAndNetworkAttachmentIgnoredWhenHalted` test can run in isolation after this change

$ TEST=TestAccXenorchestraVm_diskAndNetworkAttachmentIgnoredWhenHalted make testacc

[ ... ]

=== RUN TestAccXenorchestraVm_diskAndNetworkAttachmentIgnoredWhenHalted === PAUSE TestAccXenorchestraVm_diskAndNetworkAttachmentIgnoredWhenHalted === CONT TestAccXenorchestraVm_diskAndNetworkAttachmentIgnoredWhenHalted --- PASS: TestAccXenorchestraVm_diskAndNetworkAttachmentIgnoredWhenHalted (105.49s) PASS [DEBUG] Running sweeper ok github.com/ddelnano/terraform-provider-xenorchestra/xoa 123.809s testing: warning: no tests to run PASS ok github.com/ddelnano/terraform-provider-xenorchestra/xoa/internal 0.012s [no tests to run]