search

vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform
MIT License
150 stars 33 forks source link

Prevent dynamic memory #230

Closed hkraal closed 1 year ago

hkraal commented 1 year ago

Seems to fix #211 but I'm unsure about possible implications.

Downgrades seem to have a chance of failing with an MEMORY_CONSTRAINT_VIOLATION_ORDER. The dynamic min/max (in the XO advanced tab) are lowered but the static max is still at the old value.

ddelnano commented 1 year ago

Hey @hkraal, sorry for the late reply. I was on vacation this past week, but really appreciate you contributing!

My thinking is that there is likely implications as you mentioned, however, I need to spend some time looking into this before I can share any specific concerns. I should be able to give it a look by the end of this week / weekend.

hkraal commented 1 year ago

No rush, I'm tweaking it as I go, it works correct now for me but now it should be modified to keep backwards compatibility.

I think the introduction of a "force static memory" flag could be a possible solution. Let me know your thoughts when ready and I'll take them into account.

ddelnano commented 1 year ago

I'm targeting to have time this weekend to dig in. Apologies again for the delay!

YannickTeKulve commented 1 year ago

Hi

Any updates on this? if you need any help would love to hear it.