search

vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform
MIT License
149 stars 33 forks source link

Remove unneeded throw panic #236

Closed ravager-dk closed 5 months ago

ravager-dk commented 1 year ago

Fix for issue #232. Remove the panic thrown by having an unknown value from a separate resource. The unformattedMac is instead returned in this case. Validation still prevents using unparseble strings as mac address.

VirtualDisk commented 1 year ago

Any update on this getting merged?

ddelnano commented 1 year ago

I would like to understand how this will be accomplished in the new provider framework (as discussed here). I'm hesitant to accept a breaking change without understanding how it will be addressed in the longer term.

I unfortunately haven't had time to do that research myself since I've been traveling a lot the past month.

ravager-dk commented 9 months ago

Any updates to this? The new provider framework is not needed at the moment, and awaiting to fix issues until a complete code rewrite is done for the framework seems to me at least unnecessary. With the new Terraform license terms, not even sure we should move beyond current SDK until opentofu becomes standard. So I still suggest merging this PR.

ddelnano commented 9 months ago

@ravager-dk sorry for failing to follow up on this. I haven't spent regular time on the provider for a few months, but from this month forward I will be back on a regular schedule.

I'm currently focusing on setting up a CI build, but next week I will circle back to this.