vatesfr / terraform-provider-xenorchestra

Xen Orchestra provider for Terraform
MIT License
151 stars 32 forks source link

Remove git lfs from the repo to avoid quota exhausted issues in CI build #269

Closed ddelnano closed 12 months ago

ddelnano commented 12 months ago

Summary: Remove git lfs from the repo to avoid quota exhausted issues in CI build

One of the provider acceptance tests requires an ISO file needed to test the xenorchestra_vdi resource. This was originally accomplished by putting the ISO file in git lfs. Now that Jenkins is running nightly builds, I noticed that GitHub has a special quota for these files and this repo has exhausted it's free limit.

 > git checkout -f 9d5e64787ea2f2e36f0c4753f708ceb61a409017 # timeout=10
FATAL: Could not checkout 9d5e64787ea2f2e36f0c4753f708ceb61a409017
hudson.plugins.git.GitException: Command "git checkout -f 9d5e64787ea2f2e36f0c4753f708ceb61a409017" returned status code 128:
stdout: 
stderr: Downloading xoa/testdata/alpine-virt-3.17.0-x86_64.iso (51 MB)
Error downloading object: xoa/testdata/alpine-virt-3.17.0-x86_64.iso (8d4d53b): Smudge error: Error downloading xoa/testdata/alpine-virt-3.17.0-x86_64.iso (8d4d53bd34b2045e1e219b87887b0de8d217b6cd4a8b476a077429845a5582ba): batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.

Errors logged to '/var/lib/jenkins/workspace/ddelnano-test/.git/lfs/logs/20231007T045602.255823267.log'.
Use `git lfs logs last` to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: xoa/testdata/alpine-virt-3.17.0-x86_64.iso: smudge filter lfs failed

This change updates the dependent Makefile targets to fail if the file doesn't exist, and expects the CI system to provide this file in the expected location.

Testing done