vatesfr / xen-orchestra

The global orchestration solution to manage and backup XCP-ng and XenServer.
https://xen-orchestra.com
Other
778 stars 263 forks source link

Interface broken due to new Bootstrap Alpha #1871

Closed mkaliyannan closed 7 years ago

mkaliyannan commented 7 years ago

edit from Olivier: this is a bug from bootstrap 4 alpha 6 and the nav component.

xo-web version : 5.3

I re-builded the xo-web with current version and the UI was not loading properly. might be something missing on the build. attached screenshot.. screenshot_1

tttttx2 commented 7 years ago

Second that. I have tried multiple installs on Ubuntu server 16.04. Including his script here: https://raw.githubusercontent.com/scottalanmiller/xenorchestra_installer/master/xo_install.sh

got the same exact problem like you got...

Danp2 commented 7 years ago

Have you tried with Ubuntu 16.10?

Also, which browsers have you tried?

tttttx2 commented 7 years ago

Not yet but will do that. Browsers i tested it so far are chrome and firefox on kubuntu 16.04. Firefox has a warning, that /src/common/"somethingwithbutton"/index.css is missing.

olivierlambert commented 7 years ago

Hi guys,

Freshly built from scratch, no problems at all. Please double check your setup and provide logs if any.

mkaliyannan commented 7 years ago

I tried the same. still same issue..

lancefogle commented 7 years ago

I have the same problem on CentOS 7.3. I have tried the following:

As a side note:

xo-server shows as 5.5.4 and xo-web shows as 5.5.3 during build. Additionally, the LTS version of node has moved up from what is in your git book (v6.9.1) to v6.9.4. Running npm i -g npm installs npm version 4.0.5 now instead of v3 of npm.

If I roll back to my last working snapshot, only update and rebuild xo-server with the latest stable, it works with my existing xo-web. It only breaks when I update and rebuild xo-web with your current stable branch.

I see nothing in the logs on my server to indicate a problem and nothing in the console logs in the browser showing a missing file or anything.

olivierlambert commented 7 years ago

No error during the build phase neither?

I can't reproduce the issue at all my 2 different installations, neither on stable or next-release.

Danp2 commented 7 years ago

FWIW, I'm seeing this now as well on a brand new build. I checked on a couple of other VMs, and this issue isn't showing with xo-server 5..5.2 / xo-web 5.5.2 or on xo-server 5..5.3 / xo-web 5.5.3

olivierlambert commented 7 years ago

@Danp2 so you can't reproduce everywhere?

Danp2 commented 7 years ago

Well, I reproduced by building a new VM with the latest code. The comparison was to two prior VMs built with earlier code. It seems that something has changed with one of these class definitions (nav nav-sidebar nav-pills nav-stacked), which is causing the sidebar to be extra wide.

Danp2 commented 7 years ago

Seems to be related to the definition of 'nav'

Danp2 commented 7 years ago
.nav {
    display: flex;
    list-style: outside none none;
    margin-bottom: 0;
    padding-left: 0;
}

Removing display: flex; resolves the issue.

mkaliyannan commented 7 years ago

Same problem here. I did from scratch still no luck under FreeBSd 10.3

Sent from my iPhone

On Jan 7, 2017, at 2:18 PM, Olivier Lambert notifications@github.com wrote:

No error during the build phase neither?

I can't reproduce the issue at all my 2 different installations, neither on stable or next-release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

lancefogle commented 7 years ago

I also noticed that the quick view selector in top left doesn't respond either so you can't change to view pool, hosts, etc. I'm stuck on the VM view.

@olivierlambert I only recall seeing warnings about pre-publish being deprecated in npm@5. I can run the build again and check on a clean system to see what it does and report any errors.

SparxySys commented 7 years ago

This appears to be an issue introduced in bootstrap 4 alpha 6. If you change the bootstrap dependency to use strictly version alpha 5 the problem does not occur.

diff --git a/package.json b/package.json
index 3c5b470..f5c7647 100644
--- a/package.json
+++ b/package.json
@@ -47,7 +47,7 @@
     "babel-runtime": "^6.6.1",
     "babelify": "^7.2.0",
     "benchmark": "^2.1.0",
-    "bootstrap": "^4.0.0-alpha.5",
+    "bootstrap": "4.0.0-alpha.5",
     "browserify": "^13.0.0",
     "bundle-collapser": "^1.2.1",
     "chartist": "^0.10.1",

run npm install and npm run build after making this change

lancefogle commented 7 years ago

@DarkSpyro003 That worked for me (setting hard dependency on bootstrap 4.0.0-alpha5). As an additional note though, simply changing the package.json and running npm install && npm run build did not fix it for me. I had to completely delete my xo-web directory, pull down fresh clone, then edit the file and build for it to work.

@olivierlambert please see the attached file that contains the output from my install/build cycles on CentOS 7.3 with no errors but a few unrelated warnings (mostly deprecation warnings): build-log.txt

olivierlambert commented 7 years ago

@lancefogle yes indeed, nothing in the build log, as @DarkSpyro003 said it's very likely related to the last alpha of Bootstrap 4 (it's an alpha, therefore each release is breaking a lot of stuff).

We'll take a look to see what changed and we'll adapt our, so next rebuild will be OK after this is closed, don't stick on alpha 5.

Globally, this issue is a natural consequence of using XO from the source, as explained in the 2 big warnings of the documentation (in short: we cannot guarantee the result of of build at any time, giving the moving dependencies).

I hope nobody here used that in production :fearful:

Thanks everyone for the precious feedback!

mkaliyannan commented 7 years ago

This worked foe me

Thanks

julien-f commented 7 years ago

I fixed the dep for now.

We'll migrate when the beta will be released.