Closed Danp2 closed 6 years ago
Can you stick to LTS version of Node as indicated in our doc? Rebuild and let us know the result :)
Sure, I'll try. However, my version of Node hasn't changed in a good while.
Not sure why it was failing, even after reverting to Node 8.10. I ended up blowing away the node_modules and dist directories and now it built find. 🤷♂️
Getting the following errors with the latest XO update using Node 8.10 --
[src/api/vbd.js] Added following polyfill:
es6.promise { "node":"6" }
[14:25:55] 'buildStyles' errored after 4.92 s
[14:25:55] Error in plugin 'gulp-sass'
Message:
src/icons.scss
Error: Invalid CSS after " }": expected selector, was ","
on line 85 of src/icons.scss
from line 35 of src/index.scss
>> },
---^
Details:
status: 1
file: /opt/xen-orchestra/packages/xo-web/src/icons.scss
line: 85
column: 4
formatted: Error: Invalid CSS after " }": expected selector, was ","
on line 85 of src/icons.scss
from line 35 of src/index.scss
>> },
---^
messageFormatted: src/icons.scss
Error: Invalid CSS after " }": expected selector, was ","
on line 85 of src/icons.scss
from line 35 of src/index.scss
>> },
---^
messageOriginal: Invalid CSS after " }": expected selector, was ","
relativePath: src/icons.scss
domainEmitter: [object Object]
domain: [object Object]
domainThrown: false
[14:25:55] 'build' errored after 4.94 s
[14:25:55] The following tasks did not complete: buildScripts, copyAssets
[14:25:55] Did you forget to signal async completion?
* xo-web:build − Error: 1
Updated to Node 8.11.1, but issue remained.
Removed the commas at lines 85, 89, and 93 in xen-orchestra/packages/xo-web/src/icons.scss
and the build completed successfully.
I can confirm as well, installing with the installation script we have works without issue, even to 5.18.0. But attempting to upgrade fails and causes #2817
I can't reproduce, what's your yarn version too?
Doesn't make sense that it would initially build correctly and then fail on subsequent builds.
Yarn is 1.5.1
Okay I'm in yarn 1.3.2
and it works, I'll test with a more recent one.
Yarn is 1.5.1
Done in 82.04s.
even with yarn 1.5.1
:thinking:
Yarn 1.5.1 Node 9.10.1 and it occurred here as well.
@julien-f will take a look when he's back (Tuesday). Thanks for your report, we'll see then!
@olivierlambert Any chance this could be related to the distro involved? I know @Jarli01 and I are using Ubuntu 17.10. @thepro101 How about you?
Cool, I thought I was on node lts, but mine was v9.4.0. I will try to rebuild with LTS. I am using Debian 8.10.
@Danp2 means Ubuntu 17.10 not 11.10. . . (that would be ancient).
I'm on Debian stable.
@Danp2 must like those non-lts versions even with his OS. lol
@thepro101 LTS suck! ;-)
I believe I have isolated the cause of this issue. I have updated the xo-update script here. Please retest if you were using this script.
So every one here with the error used the script? If yes, next time please report issues directly on the script repo tracker, this would reduce our issue triage load here. Keep me posted anyway 👍
Can't speak for @thepro101 but I know that both @Jarli01 and I do. I obviously wouldn't have reported here if I knew in advance that the issue was unrelated. 😁
Context
Expected behavior
Build process to execute without issues
Current behavior
Here's the output from running the Yarn commands --