[icons.scss] Build error: Invalid CSS caused by , after }

[cocoon]

Context

• XO origin: the sources
• Versions:
  • Node: 9.2.1
  • xo-web: 5.18.0
  • xo-server: 5.18.0

Expected behavior

Compile successfully

Current behavior

Updated my Ubuntu 16.04.4 LTS today and tried to compile from the sources but it failed. I removed the two "," from the mentioned lines of icons.scss and it was OK.

Problem: https://github.com/vatesfr/xen-orchestra/blob/master/packages/xo-web/src/icons.scss#L85 https://github.com/vatesfr/xen-orchestra/blob/master/packages/xo-web/src/icons.scss#L89

Error Message:

[10:30:29] 'buildStyles' errored after 5.04 s
[10:30:29] Error in plugin 'gulp-sass'
Message:
    src/icons.scss
Error: Invalid CSS after "  }": expected selector, was ","
        on line 85 of src/icons.scss
        from line 35 of src/index.scss
>>   },

   ---^

Details:
    status: 1
    file: /opt/xen-orchestra/packages/xo-web/src/icons.scss
    line: 85
    column: 4
    formatted: Error: Invalid CSS after "  }": expected selector, was ","
        on line 85 of src/icons.scss
        from line 35 of src/index.scss
>>   },

   ---^

    messageFormatted: src/icons.scss
Error: Invalid CSS after "  }": expected selector, was ","
        on line 85 of src/icons.scss
        from line 35 of src/index.scss
>>   },

   ---^

    messageOriginal: Invalid CSS after "  }": expected selector, was ","
    relativePath: src/icons.scss
    domainEmitter: [object Object]
    domain: [object Object]
    domainThrown: false
[10:30:29] 'build' errored after 5.07 s
[10:30:29] The following tasks did not complete: buildScripts, copyAssets
[10:30:29] Did you forget to signal async completion?
* xo-web:build − Error: 1

[olivierlambert]

Hi,

How did you installed XO exactly? Because it's likely a duplicate of https://github.com/vatesfr/xen-orchestra/issues/2774

[cocoon]

Oh right yes I used the update script, too + custom scripts, thanks for the hint!

[olivierlambert]

So it's due to a problem in the build script :) Next time, if you have a build problem, please open first an issue there: https://github.com/Jarli01/xenorchestra_updater