search

vatesfr / xen-orchestra

The global orchestration solution to manage and backup XCP-ng and XenServer.
https://xen-orchestra.com
Other
767 stars 262 forks source link

CreateBridge should not contain VLAN property #4425

Closed timschneider closed 5 years ago

timschneider commented 5 years ago

Context XO origin: XenOrchestra -> Home -> Pools -> 'Selected Pool' -> Network -> Add a Network -> Bonded Network selected

https://github.com/vatesfr/xen-orchestra/blob/ae27a07578582bb61608c3dc526c5c2912050b55/packages/xo-web/src/xo-app/new/network/index.js#L118-L126 Versions: Node: XCP-ng 7.6.0 xo-web: xo-web 5.44.0 xo-server: xo-server 5.44.0 Expected behavior After fill in the required informations, e.g. interfaces, name, bond mode, and pressing Create Network, the bonded network should be created.

Current behavior The creation fails with the following error message:

t {code: 10, data: {…}, message: "invalid parameters", name: "t", stack: "t: invalid parameters↵    at t.<anonymous> (http:/…nymous> (http://192.168.172.7/index.js:1:2851714)"}code: 10data: errors: Array(1)0: code: nullmessage: "should not contains property ["vlan"]"property: "@"reason: "strict"__proto__: Objectlength: 1__proto__: Array(0)__proto__: Objectmessage: "invalid parameters"name: "t"stack: "t: invalid parameters↵    at t.<anonymous> (http://192.168.172.7/index.js:1:2851158)↵    at S (http://192.168.172.7/index.js:1:2566426)↵    at Generator._invoke (http://192.168.172.7/index.js:1:2566214)↵    at Generator.e.<computed> [as next] (http://192.168.172.7/index.js:1:2566605)↵    at n (http://192.168.172.7/index.js:1:212570)↵    at http://192.168.172.7/index.js:1:212711↵    at new Promise (<anonymous>)↵    at new t (http://192.168.172.7/index.js:1:407616)↵    at t.<anonymous> (http://192.168.172.7/index.js:1:212505)↵    at t.<anonymous> (http://192.168.172.7/index.js:1:2851714)"__proto__: i
(anonymous) @ log-error.js:10
setTimeout (async)
r.default @ log-error.js:5
(anonymous) @ action-button.js:118
S @ runtime.js:62
(anonymous) @ runtime.js:296
e.<computed> @ runtime.js:114
n @ asyncToGenerator.js:17
(anonymous) @ asyncToGenerator.js:30
Promise.then (async)
n @ asyncToGenerator.js:27
(anonymous) @ asyncToGenerator.js:35
t @ _export.js:36
(anonymous) @ asyncToGenerator.js:14
(anonymous) @ action-button.js:121
o._eventListener @ action-button.js:131

Solution:

please remove the VLAN property from createBondedNetwork, it will cause the error. When removing the vlan property in the javascript debug window in browser, the bond will be created without errors.

olivierlambert commented 5 years ago

Hi,

Can you follow the issue template please? We lack a lot of details here.

timschneider commented 5 years ago

@olivierlambert Sorry I didn't read the issue template in advance- I've changed my first post to comply with the template.

olivierlambert commented 5 years ago

Thanks :+1: Can you try on a more up to date code XO code? I don't know if it changed, but you are not on the latest one.

timschneider commented 5 years ago

sure, but anyhow, as far as I know is my current XO version the latest stable release right?

timschneider commented 5 years ago

I can confirm the same behaviour for the following version:

olivierlambert commented 5 years ago

You are using XOA or XO from the sources? (just to be sure, because from the sources there isn't any stable)

timschneider commented 5 years ago

I'm running the Xen Orchestra virtual Appliance (XOA) updated to the last version in "latest update channel" now.

olivierlambert commented 5 years ago

Okay, so you confirm you still have the problem, right?

timschneider commented 5 years ago

Yes, it's still there and if I remove the vlan element from param, I can create the bond as expected.

julien-f commented 5 years ago

This appears to be an xo-web issue.