Open JustinTimperio opened 4 years ago
Do we even have those icons in our current pack @Rajaa-BARHTAOUI ?
@olivierlambert @Rajaa-BARHTAOUI Out of curiosity I started digging through this massive repo trying to figure out where these icons actually existed. I see that OS Icons are defined here but unfortunately Font Awesome does not contain Arch Linux or Alpine Linux Icons.
Thankfully though Iconify which is a unified icons framework (includes Font Awesome, Material Design Icons, Unicons...) has icons for both Arch Linux and Apline Linux. You can import this framework as a basic component, or call icons using the React API. I understand though if you don't want to use this framework and add yet another dependency to this project.
Ping also @julien-f
Reping @julien-f and @Rajaa-BARHTAOUI
I think this will wait for XO 6.
If you want this in XO 5, a small PR may help :slightly_smiling_face:
I'm not much of a front-end dev but I'll see if I can pull a PR together this weekend.
Well, this was a fabulous reminder of why I never touch the frontend. I was able to get this working slightly but not in a way that is PR worthy or even close to prod ready. I will leave this to professionals.
Here is a list of all the distros missing icons that will be supported by the next generation of Xen guest tools.
@julien-f I look forward to the XO 6 Release!
@julien-f Rocky Linux is in this boat as well. It has been included in @stormi's updates to the xcp-ng guest tools and works now to report in XO but no icon.
Let's also add AlmaLinux which is the other CentOS fork with Rocky Linux.
As long as we don't have any icon in upstream projects we use for icon, there's little we can do.
why don't take the official icons? https://github.com/rocky-linux/branding https://github.com/rocky-linux/rocky-logos
We'll be happy to have your contribution on adding those icons :) If you need help on how to do it correctly, let us know!
need a guide how to do this.
@pdonias can you give him some pointers?
if you mean add a new icon to https://github.com/fizzed/font-mfizz which is used for most icons, this repo dead for 5 years. That's why Ubuntu icon style outdated, new one at https://github.com/FortAwesome/Font-Awesome
bump
@TristisOris We have a lot of stuff on our plate, this will be fixed in XO6 and not XO5.
thanks.
It's mid-2024 and XO 6 hasn't been released yet, and so no icons either.
Fully agree, we need these:
Alpine Linux
AlmaLinux
Arch Linux
Gentoo
Kali Linux
NixOS
OpenSUSE
ParrotOS
RockyLinux
Also, 100% support the idea that for unknown distros it should show an icon with question mark. If only devs would explain how icons & fetching etc. etc. works, we could have made a community PR for that. I've tried looking at the code but couldn't understand full logic and procedure for that.
XO 6 first preview has been released, see https://xen-orchestra.com/blog/xen-orchestra-5-95#xo-6-first-preview
It's not even certain how relevant this will be in the new UI, we'll need to discuss with our UX designer, @clemencebx
Context
Expected behavior
Icon Support for Arch Linux and Alpine Linux which both have working Xen tools. I personally use Arch Linux the most frequently and it would be awesome to have icons in XO.
Current behavior