vatesfr / xen-orchestra

The global orchestration solution to manage and backup XCP-ng and XenServer.
https://xen-orchestra.com
Other
774 stars 262 forks source link

Enhancement: Add Icons for Arch Linux and Alpine Linux #5261

Open JustinTimperio opened 4 years ago

JustinTimperio commented 4 years ago

Context

Expected behavior

Icon Support for Arch Linux and Alpine Linux which both have working Xen tools. I personally use Arch Linux the most frequently and it would be awesome to have icons in XO.

Current behavior

image

olivierlambert commented 4 years ago

Do we even have those icons in our current pack @Rajaa-BARHTAOUI ?

JustinTimperio commented 4 years ago

@olivierlambert @Rajaa-BARHTAOUI Out of curiosity I started digging through this massive repo trying to figure out where these icons actually existed. I see that OS Icons are defined here but unfortunately Font Awesome does not contain Arch Linux or Alpine Linux Icons.

Thankfully though Iconify which is a unified icons framework (includes Font Awesome, Material Design Icons, Unicons...) has icons for both Arch Linux and Apline Linux. You can import this framework as a basic component, or call icons using the React API. I understand though if you don't want to use this framework and add yet another dependency to this project.

olivierlambert commented 4 years ago

Ping also @julien-f

JustinTimperio commented 4 years ago

I'm gonna also add OpenSUSE and Gentoo to this request.

olivierlambert commented 4 years ago

Reping @julien-f and @Rajaa-BARHTAOUI

julien-f commented 4 years ago

I think this will wait for XO 6.

If you want this in XO 5, a small PR may help :slightly_smiling_face:

JustinTimperio commented 4 years ago

I'm not much of a front-end dev but I'll see if I can pull a PR together this weekend.

JustinTimperio commented 3 years ago

Well, this was a fabulous reminder of why I never touch the frontend. I was able to get this working slightly but not in a way that is PR worthy or even close to prod ready. I will leave this to professionals.

Here is a list of all the distros missing icons that will be supported by the next generation of Xen guest tools.

@julien-f I look forward to the XO 6 Release!

lancefogle commented 3 years ago

@julien-f Rocky Linux is in this boat as well. It has been included in @stormi's updates to the xcp-ng guest tools and works now to report in XO but no icon.

stormi commented 2 years ago

Let's also add AlmaLinux which is the other CentOS fork with Rocky Linux.

olivierlambert commented 2 years ago

As long as we don't have any icon in upstream projects we use for icon, there's little we can do.

TristisOris commented 2 years ago

why don't take the official icons? https://github.com/rocky-linux/branding https://github.com/rocky-linux/rocky-logos

olivierlambert commented 2 years ago

We'll be happy to have your contribution on adding those icons :) If you need help on how to do it correctly, let us know!

TristisOris commented 2 years ago

need a guide how to do this.

olivierlambert commented 2 years ago

@pdonias can you give him some pointers?

TristisOris commented 2 years ago

if you mean add a new icon to https://github.com/fizzed/font-mfizz which is used for most icons, this repo dead for 5 years. That's why Ubuntu icon style outdated, new one at https://github.com/FortAwesome/Font-Awesome

TristisOris commented 2 years ago

bump

julien-f commented 2 years ago

@TristisOris We have a lot of stuff on our plate, this will be fixed in XO6 and not XO5.

TristisOris commented 2 years ago

thanks.

belohnung commented 1 year ago

Adding NixOS would be appreciated too, on another note, would a generic icon for OSs we don't have icons for work? At least the tooltip with the guest os info could be shown then, this could even be implemented with the current icon pack with an icon like this.

sxiii commented 3 months ago

It's mid-2024 and XO 6 hasn't been released yet, and so no icons either.

Fully agree, we need these:

Alpine Linux
AlmaLinux
Arch Linux
Gentoo
Kali Linux
NixOS
OpenSUSE
ParrotOS
RockyLinux

Also, 100% support the idea that for unknown distros it should show an icon with question mark. If only devs would explain how icons & fetching etc. etc. works, we could have made a community PR for that. I've tried looking at the code but couldn't understand full logic and procedure for that.

olivierlambert commented 3 months ago

XO 6 first preview has been released, see https://xen-orchestra.com/blog/xen-orchestra-5-95#xo-6-first-preview

It's not even certain how relevant this will be in the new UI, we'll need to discuss with our UX designer, @clemencebx