search

vatesfr / xen-orchestra

The global orchestration solution to manage and backup XCP-ng and XenServer.
https://xen-orchestra.com
Other
775 stars 262 forks source link

VM delete improvment proposal #5548

Open marekhel opened 3 years ago

marekhel commented 3 years ago

Context

Expected behavior

User should be informed about VM to be deleted. I would suggest to include following options:

Current behavior

Right now user is notified about VM deletion, without name and just with a click. image

pdonias commented 3 years ago

Hi, thanks for your report!

Display VM name to be deleted, with bold.

Are you talking about VM deletion from the Home page only? What if there's more than 1 VM selected? Displaying all the VMs' names would make the modal too crowded, don't you think?

Ask user to put an input, eg. 'delete' or 'delete all', before user can delete VM(s). That will ensure accidental deletion

This is what we do when you try to delete more than 1 VM. If you delete only 1 VM, we keep the same behavior as when you delete it from the VM page directly, so that you don't have to type something every time you want to delete a VM.

However, if you want to add an extra layer of protection for some important VMs, you can enable the "Protect from accidental deletion" option from the VM's Advanced tab.

marekhel commented 3 years ago

Are you talking about VM deletion from the Home page only? What if there's more than 1 VM selected? Displaying all the VMs' names would make the modal too crowded, don't you think?

I think it wouldn't be an issue. This popup is really small and it can grow much. It's worth consideration.

If you delete only 1 VM, we keep the same behavior as when you delete it from the VM page directly, so that you don't have to type something every time you want to delete a VM.

Yes, I picked VM from all VMs page (tick one and click delete) but I feel this really mistake prone, so I prefer to delete from a given VM page.

pdonias commented 3 years ago

I'm not sure I'm getting what you mean. You're saying that you don't like to delete a VM from the Home page because there isn't enough protection, so you prefer to delete it from the VM page. But there isn't any extra protection there either. The only real protection to avoid deleting a VM by mistake is the "Prevent from accidental deletion" option.

As for displaying the VMs' names, I agree it wouldn't get too crowded with a few VMs, but this is mostly a protection from deleting a lot of VMs at once without realizing how many VMs you selected. And for a large number of VMs, I wonder how helpful it would be to display their names.

marekhel commented 3 years ago

I delete from VM page rather than VM list page as I dont need to check what I checked for delete. About listing VM names, let's think who delete big number of VMs manually and whats the frequency of such operation in contrast to single VM deletion. I think much more people remove one/few VMs, not many of them - for such scale deployments automation should be employed.