Improve XCP-ng updates display - Display when an host is upgrading

[benjamreis]

We had some report on XCP-ng side that the XCP-ng display can be misleading and sometimes lead to a user breaking its install (see https://xcp-ng.org/forum/topic/4724/kernel-panic-after-latest-patches)

I've been playing around with the updater plugin and the update view in XO so here's what I can say:

The updater

The updater has a mechanism to not be ran twice, so it's possible to see if an update is ongoing:

[11:04 xcp-ng-findqbvm ~]# xe host-call-plugin host-uuid=d267d9b4-fa25-4106-9719-8d108d87b219  plugin=updater.py fn=check_update
{"error": "The updater plugin is busy (current operation: update)"}
[11:04 xcp-ng-findqbvm ~]# xe host-call-plugin host-uuid=d267d9b4-fa25-4106-9719-8d108d87b219  plugin=updater.py fn=update
{"error": "Update already in progress"}

But XO throw this:

pool.installPatches
{
  "hosts": [
    "d267d9b4-fa25-4106-9719-8d108d87b219"
  ]
}
{
  "message": "",
  "name": "Error",
  "stack": "Error: 
    at Xapi._xcpUpdate (file:///usr/local/lib/node_modules/xo-server/src/xapi/mixins/patching.mjs:323:15)
    at Object.installPatches (file:///usr/local/lib/node_modules/xo-server/src/api/pool.mjs:100:3)
    at Api.callApiMethod (file:///usr/local/lib/node_modules/xo-server/src/xo-mixins/api.mjs:304:20)"
}

IMHO an "host is upgrading" icon/message would be better.

Also I'm currently adding a XAPI task when an host is upgrading so that'd be helpful for XCP-ng 8.3+.

XO host updates view

Here's are some weird behavior I encountered while using XO to update my hosts:

• When the host is updating, if you reloead the host update view (Ctrl+R) it is displayed as up to date even though the update is ongoing.
• When the host is updating, if you leave the update tab & comeback it shows: An error occurred while fetching the patches. Please make sure the updater plugin is installed by running yum install xcp-ng-updater on the host.
• When trying the install the patches twice, the error is badly displayed as mentionned above

=> an upgrading woudl solve all of the above issues if it prevents a user from rebooting, trying to install update on the hosts etc.

What do you think?

[julien-f]

All plugins now throw in case of errors.

List of plugins used by XO:

• updater.py
  • check_update: not impacted
  • update: no longer a JSON, returns a task ref
• netdata.py
  • install_netdata: not impacted
  • get_netdata_api_key: not impacted
  • is_netdata_installed: not impacted
• zfs.py: not impacted
• xosan.py: not impacted
• install-supp-pack: not impacted
• xscontainer: not impacted
• hyperthreading.py: not impacted

[olivierlambert]

To do in Q3, someone needs to be assigned.