search

vatesfr / xen-orchestra

The global orchestration solution to manage and backup XCP-ng and XenServer.
https://xen-orchestra.com
Other
795 stars 265 forks source link

Warn before creating a local SR - the device will be formatted #5996

Closed stormi closed 2 years ago

stormi commented 3 years ago

Is your feature request related to a problem? Please describe.

From time to time, users lose important data on their disks because they are not aware that local SR creation formats the target device (except for ZFS SRs because we let users handle the volume creation).

Recent example: https://xcp-ng.org/forum/topic/5179/formate-a-xfs-disk-with-lvm-by-accident-need-help-please

Describe the solution you'd like

Adding a warning in XO just before the SR creation would be a good safeguard.

Describe alternatives you've considered

We'll also add a warning in the docs, but this won't be visible enough.

marcungeschikts commented 3 years ago

Should be planned for Christmas release (5.66). TBC

stormi commented 2 years ago

Done in last XO release IIRC.