Open TristisOris opened 2 years ago
same if disable pool, i got error, but backup for other pools works.
I agree with you, the backup should run on other non-disabled remotes.
Regarding your second comment, I believe it works as expected (ie the backup run on connected pools), am I right?
it's a problem if pool really not available. But if i disabled it manually, no reasons to report this.
tested with 1 disabled remote - no any errors, works perfect.
@fbeauchamp this commit broke the Continuous Replication.
backupNg.runJob
{
"id": "61ce232b-fe91-4f47-b137-f7c3f8b00382",
"schedule": "f1eaaacc-7b82-4611-a2c1-e89d6ecbd3d4"
}
{
"errors": {},
"message": "couldn't instantiate any remote",
"name": "Error",
"stack": "Error: couldn't instantiate any remote
at executor (file:///opt/xo/xo-builds/xen-orchestra-202209261824/packages/xo-server/src/xo-mixins/backups-ng/index.mjs:233:27)
at file:///opt/xo/xo-builds/xen-orchestra-202209261824/packages/xo-server/src/xo-mixins/jobs/index.mjs:263:30
at Jobs._runJob (file:///opt/xo/xo-builds/xen-orchestra-202209261824/packages/xo-server/src/xo-mixins/jobs/index.mjs:292:22)
at Jobs.runJobSequence (file:///opt/xo/xo-builds/xen-orchestra-202209261824/packages/xo-server/src/xo-mixins/jobs/index.mjs:332:7)
at Api.#callApiMethod (file:///opt/xo/xo-builds/xen-orchestra-202209261824/packages/xo-server/src/xo-mixins/api.mjs:394:20)"
}
also it didn't work for Pool metadata & XO config backup - old error remote is disabled
And i didn't test Rolling and DR jobs.
commit d87210e903a69a6ff09af5d2ac270fec34322038
CR backup fixed, metadata still remote is disabled
.
Hi @TristisOris
In my test the backup metadata run successfully on enabled remote(s) and failed on a disabled one , like this , with local flo
disabled , in a job with pool and xo config backup :
Is it the same for you ? regards
hm yes, my bad. Job total status - fail, but it only fail for disabled remote. All other tasks completed. Maybe hide this error to not get any email about this task? Same as for usual backup.
Is your feature request related to a problem? Please describe. i'm doing backup into 2 remotes. Need to disable 1 for maintenance, but all backups now failed because it not available.
Describe the solution you'd like Do backup to any available remotes, skip others.
Additional context
![Untitled2](https://user-images.githubusercontent.com/1270117/185496659-45e8f7aa-7544-4d66-98af-a59296cdbe35.png)
as i see, backup itself don't know that it not just unavailable, but disabled at XO.
Xen Orchestra, commit [2f38e] xo-server 5.100.1 xo-web 5.101.1