VM Import - Typo/Confusing Verbage

[Jarli01]

Are you using XOA or XO from the sources?

XOA

Which release channel?

stable

Provide your commit number

aefcc

Describe the bug

Import VM screen "Network VM Network" see screenshot

Error message

No response

To reproduce

1. Go to 'Import'
2. Click on 'drop an OVA into the import menu'
3. See the "Network VM Network"

Expected behavior

The verbiage is weird, and unclear, is this the network that will be used to Import the VM or is this eventual network adapter that the VM will be using?

Screenshots

Node

18.19.1

Hypervisor

XCP-8.2.1

Additional context

No response

[olivierlambert]

Nice catch, thanks!

[julien-f]

I agree it's misleading but what it means is that it's the network named VM Network.

See:

• https://github.com/vatesfr/xen-orchestra/blob/9cb94010fec87d9f01d794788e3affc8fa01452a/packages/xo-web/src/common/intl/messages.js#L1771
• https://github.com/vatesfr/xen-orchestra/blob/9cb94010fec87d9f01d794788e3affc8fa01452a/%40xen-orchestra/vmware-explorer/parsers/vmx.mjs#L102

Ping @fbeauchamp

[Jarli01]

@julien-f right, but a network named "VM Network" isn't authoritative to if its the network adapter that will be applied to the imported VM, which is what I believe the field is trying to relay.

Might I suggest for a header: "VM Adapter Selection"

or "Network Adapter to Apply to Import"

[Jarli01]

Or possibly "Post-Import Network Adapter Selection"