fix(backups): EEXIST error when restarting mirror backup - Githubissues

vatesfr / xen-orchestra

The global orchestration solution to manage and backup XCP-ng and XenServer.

https://xen-orchestra.com

Other

741 stars 259 forks source link

fix(backups): EEXIST error when restarting mirror backup #7694

Closed fbeauchamp closed 1 week ago

fbeauchamp commented 1 month ago

Description

cleanVm can only delete files when backup job is successful
an interrupted transfer leave the temp file in place
the temp file don't change name in a mirror backup since we transfer exactly the same file
outputStream method use, by default, a flag that create the file if not exists and fail otherwise
=> EEXIST error

This PR change the behaviour of cleanVM to delete temporary files on the pass before the transfer, thus removing any dot file

Checklist

Commit
- Title follows commit conventions
- Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
- If bug fix, add Introduced by
Changelog
- If visible by XOA users, add changelog entry
- Update "Packages to release" in CHANGELOG.unreleased.md
PR
- If UI changes, add screenshots
- If not finished or not tested, open as Draft